Console call frame line/column numbers are one-based. While debugger line/column numbers are zero-based. We should make our protocol consistent in this respect.
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/6667812b2dffe3f6bf794b2b040504e5a3ad7cb7 commit 6667812b2dffe3f6bf794b2b040504e5a3ad7cb7 Author: kozyatinskiy <kozyatinskiy@chromium.org> Date: Sat Jul 09 18:03:05 2016 [DevTools] Better ExceptionDetails in js_protocol.json - line/column -> lineNumber/columnNumber - lineNumber is 0-based - ExceptionDetails is hidden - fixed +/-1 error R=dgozman@chromium.org BUG= 591496 Review-Url: https://codereview.chromium.org/2130203002 Cr-Commit-Position: refs/heads/master@{#404564} [add] https://crrev.com/6667812b2dffe3f6bf794b2b040504e5a3ad7cb7/third_party/WebKit/LayoutTests/inspector-protocol/console/console-line-and-column-expected.txt [add] https://crrev.com/6667812b2dffe3f6bf794b2b040504e5a3ad7cb7/third_party/WebKit/LayoutTests/inspector-protocol/console/console-line-and-column.html [add] https://crrev.com/6667812b2dffe3f6bf794b2b040504e5a3ad7cb7/third_party/WebKit/LayoutTests/inspector-protocol/runtime/runtime-compileScript-expected.txt [add] https://crrev.com/6667812b2dffe3f6bf794b2b040504e5a3ad7cb7/third_party/WebKit/LayoutTests/inspector-protocol/runtime/runtime-compileScript.html [modify] https://crrev.com/6667812b2dffe3f6bf794b2b040504e5a3ad7cb7/third_party/WebKit/LayoutTests/inspector/sources/compile-javascript-expected.txt [modify] https://crrev.com/6667812b2dffe3f6bf794b2b040504e5a3ad7cb7/third_party/WebKit/LayoutTests/inspector/sources/debugger/debugger-compile-and-run-expected.txt [modify] https://crrev.com/6667812b2dffe3f6bf794b2b040504e5a3ad7cb7/third_party/WebKit/LayoutTests/inspector/sources/debugger/debugger-compile-and-run.html [modify] https://crrev.com/6667812b2dffe3f6bf794b2b040504e5a3ad7cb7/third_party/WebKit/Source/devtools/front_end/console/ConsoleView.js [modify] https://crrev.com/6667812b2dffe3f6bf794b2b040504e5a3ad7cb7/third_party/WebKit/Source/devtools/front_end/snippets/ScriptSnippetModel.js [modify] https://crrev.com/6667812b2dffe3f6bf794b2b040504e5a3ad7cb7/third_party/WebKit/Source/devtools/front_end/sources/JavaScriptCompiler.js [modify] https://crrev.com/6667812b2dffe3f6bf794b2b040504e5a3ad7cb7/third_party/WebKit/Source/platform/v8_inspector/InjectedScript.cpp [modify] https://crrev.com/6667812b2dffe3f6bf794b2b040504e5a3ad7cb7/third_party/WebKit/Source/platform/v8_inspector/js_protocol.json
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/392d19d496f2c166a53438add0c8065cdd6f6a1d commit 392d19d496f2c166a53438add0c8065cdd6f6a1d Author: kozyatinskiy <kozyatinskiy@chromium.org> Date: Wed Jul 13 02:42:35 2016 [DevTools] make Runtime.CallFrame 0-based Next steps: - make profiler's types 0-based - make backend Stack Trace 0-based - console message 0-based R=dgozman@chromium.org BUG= 591496 Review-Url: https://codereview.chromium.org/2145483002 Cr-Commit-Position: refs/heads/master@{#404923} [modify] https://crrev.com/392d19d496f2c166a53438add0c8065cdd6f6a1d/third_party/WebKit/LayoutTests/http/tests/inspector/debugger-test.js [modify] https://crrev.com/392d19d496f2c166a53438add0c8065cdd6f6a1d/third_party/WebKit/LayoutTests/http/tests/inspector/network/network-document-initiator-expected.txt [modify] https://crrev.com/392d19d496f2c166a53438add0c8065cdd6f6a1d/third_party/WebKit/LayoutTests/http/tests/inspector/network/network-initiator-expected.txt [modify] https://crrev.com/392d19d496f2c166a53438add0c8065cdd6f6a1d/third_party/WebKit/LayoutTests/http/tests/inspector/sources/debugger/async-callstack-network-initiator-image-expected.txt [modify] https://crrev.com/392d19d496f2c166a53438add0c8065cdd6f6a1d/third_party/WebKit/LayoutTests/http/tests/inspector/stacktraces/csp-inline-warning-contains-stacktrace-expected.txt [modify] https://crrev.com/392d19d496f2c166a53438add0c8065cdd6f6a1d/third_party/WebKit/LayoutTests/http/tests/inspector/stacktraces/csp-setInterval-warning-contains-stacktrace-expected.txt [modify] https://crrev.com/392d19d496f2c166a53438add0c8065cdd6f6a1d/third_party/WebKit/LayoutTests/http/tests/inspector/stacktraces/csp-setTimeout-warning-contains-stacktrace-expected.txt [modify] https://crrev.com/392d19d496f2c166a53438add0c8065cdd6f6a1d/third_party/WebKit/LayoutTests/inspector-protocol/console/console-line-and-column-expected.txt [modify] https://crrev.com/392d19d496f2c166a53438add0c8065cdd6f6a1d/third_party/WebKit/LayoutTests/inspector-protocol/network/websocket-initiator-expected.txt [modify] https://crrev.com/392d19d496f2c166a53438add0c8065cdd6f6a1d/third_party/WebKit/LayoutTests/inspector/console/console-eval-exception-report-expected.txt [modify] https://crrev.com/392d19d496f2c166a53438add0c8065cdd6f6a1d/third_party/WebKit/LayoutTests/inspector/sources/debugger/debugger-compile-and-run-expected.txt [modify] https://crrev.com/392d19d496f2c166a53438add0c8065cdd6f6a1d/third_party/WebKit/Source/devtools/front_end/bindings/PresentationConsoleMessageHelper.js [modify] https://crrev.com/392d19d496f2c166a53438add0c8065cdd6f6a1d/third_party/WebKit/Source/devtools/front_end/components/Linkifier.js [modify] https://crrev.com/392d19d496f2c166a53438add0c8065cdd6f6a1d/third_party/WebKit/Source/devtools/front_end/profiler/CPUProfileView.js [modify] https://crrev.com/392d19d496f2c166a53438add0c8065cdd6f6a1d/third_party/WebKit/Source/devtools/front_end/profiler/HeapProfileView.js [modify] https://crrev.com/392d19d496f2c166a53438add0c8065cdd6f6a1d/third_party/WebKit/Source/devtools/front_end/sdk/DebuggerModel.js [modify] https://crrev.com/392d19d496f2c166a53438add0c8065cdd6f6a1d/third_party/WebKit/Source/devtools/front_end/timeline/TimelineTreeView.js [modify] https://crrev.com/392d19d496f2c166a53438add0c8065cdd6f6a1d/third_party/WebKit/Source/devtools/front_end/timeline/TimelineUIUtils.js [modify] https://crrev.com/392d19d496f2c166a53438add0c8065cdd6f6a1d/third_party/WebKit/Source/platform/v8_inspector/V8StackTraceImpl.cpp [modify] https://crrev.com/392d19d496f2c166a53438add0c8065cdd6f6a1d/third_party/WebKit/Source/platform/v8_inspector/js_protocol.json
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/4aab40a95c7c9f01d7c258c1095b13f5c75300eb commit 4aab40a95c7c9f01d7c258c1095b13f5c75300eb Author: kozyatinskiy <kozyatinskiy@chromium.org> Date: Fri Jul 15 01:37:16 2016 [DevTools] Add callFrame to CPUProfileNode & SamplingHeapProfileNode - functionName, scriptId, url, lineNumber, columnNumber -> callFrame (Runtime.CallFrame); - callFrame.lineNumber & callFrame.columnNumber are 0-based - fix closure compiler types in CPUProfileDataModel.js R=dgozman@chromium.org,alph@chromium.org BUG= 591496 Review-Url: https://codereview.chromium.org/2150803002 Cr-Commit-Position: refs/heads/master@{#405670} [modify] https://crrev.com/4aab40a95c7c9f01d7c258c1095b13f5c75300eb/third_party/WebKit/LayoutTests/inspector-protocol/cpu-profiler/console-profile.html [modify] https://crrev.com/4aab40a95c7c9f01d7c258c1095b13f5c75300eb/third_party/WebKit/LayoutTests/inspector-protocol/heap-profiler/sampling-heap-profiler-expected.txt [modify] https://crrev.com/4aab40a95c7c9f01d7c258c1095b13f5c75300eb/third_party/WebKit/LayoutTests/inspector-protocol/heap-profiler/sampling-heap-profiler.html [modify] https://crrev.com/4aab40a95c7c9f01d7c258c1095b13f5c75300eb/third_party/WebKit/LayoutTests/inspector/profiler/cpu-profiler-bottom-up-large-tree-search.html [modify] https://crrev.com/4aab40a95c7c9f01d7c258c1095b13f5c75300eb/third_party/WebKit/LayoutTests/inspector/profiler/cpu-profiler-bottom-up-times.html [modify] https://crrev.com/4aab40a95c7c9f01d7c258c1095b13f5c75300eb/third_party/WebKit/LayoutTests/inspector/profiler/cpu-profiler-flame-chart-overview.html [modify] https://crrev.com/4aab40a95c7c9f01d7c258c1095b13f5c75300eb/third_party/WebKit/LayoutTests/inspector/profiler/cpu-profiler-native-nodes-filter.html [modify] https://crrev.com/4aab40a95c7c9f01d7c258c1095b13f5c75300eb/third_party/WebKit/LayoutTests/inspector/tracing/timeline-js/timeline-js-line-level-profile.html [modify] https://crrev.com/4aab40a95c7c9f01d7c258c1095b13f5c75300eb/third_party/WebKit/LayoutTests/inspector/tracing/trace-event-self-time.html [modify] https://crrev.com/4aab40a95c7c9f01d7c258c1095b13f5c75300eb/third_party/WebKit/Source/devtools/front_end/profiler/CPUProfileView.js [modify] https://crrev.com/4aab40a95c7c9f01d7c258c1095b13f5c75300eb/third_party/WebKit/Source/devtools/front_end/profiler/HeapProfileView.js [modify] https://crrev.com/4aab40a95c7c9f01d7c258c1095b13f5c75300eb/third_party/WebKit/Source/devtools/front_end/profiler/ProfileView.js [modify] https://crrev.com/4aab40a95c7c9f01d7c258c1095b13f5c75300eb/third_party/WebKit/Source/devtools/front_end/sdk/CPUProfileDataModel.js [modify] https://crrev.com/4aab40a95c7c9f01d7c258c1095b13f5c75300eb/third_party/WebKit/Source/devtools/front_end/sdk/ProfileTreeModel.js [modify] https://crrev.com/4aab40a95c7c9f01d7c258c1095b13f5c75300eb/third_party/WebKit/Source/platform/v8_inspector/V8HeapProfilerAgentImpl.cpp [modify] https://crrev.com/4aab40a95c7c9f01d7c258c1095b13f5c75300eb/third_party/WebKit/Source/platform/v8_inspector/V8ProfilerAgentImpl.cpp [modify] https://crrev.com/4aab40a95c7c9f01d7c258c1095b13f5c75300eb/third_party/WebKit/Source/platform/v8_inspector/js_protocol.json
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/0b312cc5e879525938bd96564e933f1cd996761b commit 0b312cc5e879525938bd96564e933f1cd996761b Author: kozyatinskiy <kozyatinskiy@chromium.org> Date: Fri Jul 15 19:54:36 2016 [DevTools] Fix line and column in CallstackSidebarPane for async frames Since Runtime.CallFrame is 0-based, subtraction of 1 from line and column is redundant. It was broken in: refs/heads/master@{#404923} (https://codereview.chromium.org/2145483002/). BUG= 591496 R=lushnikov@chromium.org Review-Url: https://codereview.chromium.org/2153893002 Cr-Commit-Position: refs/heads/master@{#405831} [add] https://crrev.com/0b312cc5e879525938bd96564e933f1cd996761b/third_party/WebKit/LayoutTests/inspector/sources/debugger-ui/async-call-stack-url-expected.txt [add] https://crrev.com/0b312cc5e879525938bd96564e933f1cd996761b/third_party/WebKit/LayoutTests/inspector/sources/debugger-ui/async-call-stack-url.html [modify] https://crrev.com/0b312cc5e879525938bd96564e933f1cd996761b/third_party/WebKit/Source/devtools/front_end/sources/CallStackSidebarPane.js
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/ce719653064ea664fc422579441bfee3454ccb19 commit ce719653064ea664fc422579441bfee3454ccb19 Author: kozyatinskiy <kozyatinskiy@chromium.org> Date: Fri Jul 15 23:35:50 2016 [DevTools] Replace SetScriptSourceError with ExceptionDetails in protocol BUG= 591496 R=dgozman@chromium.org Review-Url: https://codereview.chromium.org/2146333003 Cr-Commit-Position: refs/heads/master@{#405898} [modify] https://crrev.com/ce719653064ea664fc422579441bfee3454ccb19/third_party/WebKit/LayoutTests/inspector-protocol/debugger/setScriptSource-expected.txt [modify] https://crrev.com/ce719653064ea664fc422579441bfee3454ccb19/third_party/WebKit/LayoutTests/inspector-protocol/debugger/setScriptSource.html [modify] https://crrev.com/ce719653064ea664fc422579441bfee3454ccb19/third_party/WebKit/Source/devtools/front_end/bindings/ResourceScriptMapping.js [modify] https://crrev.com/ce719653064ea664fc422579441bfee3454ccb19/third_party/WebKit/Source/devtools/front_end/sdk/DebuggerModel.js [modify] https://crrev.com/ce719653064ea664fc422579441bfee3454ccb19/third_party/WebKit/Source/devtools/front_end/sdk/Script.js [modify] https://crrev.com/ce719653064ea664fc422579441bfee3454ccb19/third_party/WebKit/Source/platform/v8_inspector/V8DebuggerAgentImpl.cpp [modify] https://crrev.com/ce719653064ea664fc422579441bfee3454ccb19/third_party/WebKit/Source/platform/v8_inspector/V8DebuggerAgentImpl.h [modify] https://crrev.com/ce719653064ea664fc422579441bfee3454ccb19/third_party/WebKit/Source/platform/v8_inspector/V8DebuggerImpl.cpp [modify] https://crrev.com/ce719653064ea664fc422579441bfee3454ccb19/third_party/WebKit/Source/platform/v8_inspector/V8DebuggerImpl.h [modify] https://crrev.com/ce719653064ea664fc422579441bfee3454ccb19/third_party/WebKit/Source/platform/v8_inspector/js_protocol.json
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/6d1e7a0c7e9257bff65c15ff4c2161ea448f8751 commit 6d1e7a0c7e9257bff65c15ff4c2161ea448f8751 Author: kozyatinskiy <kozyatinskiy@chromium.org> Date: Wed Jul 20 02:34:04 2016 [DevTools] Make WebInspector.ConsoleMessage 0-based BUG= 591496 R=dgozman@chromium.org Review-Url: https://codereview.chromium.org/2163803002 Cr-Commit-Position: refs/heads/master@{#406469} [modify] https://crrev.com/6d1e7a0c7e9257bff65c15ff4c2161ea448f8751/third_party/WebKit/LayoutTests/http/tests/inspector-enabled/console-log-before-frame-navigation-expected.txt [modify] https://crrev.com/6d1e7a0c7e9257bff65c15ff4c2161ea448f8751/third_party/WebKit/LayoutTests/http/tests/inspector/stacktraces/csp-inline-warning-contains-stacktrace-expected.txt [modify] https://crrev.com/6d1e7a0c7e9257bff65c15ff4c2161ea448f8751/third_party/WebKit/LayoutTests/http/tests/inspector/stacktraces/csp-setInterval-warning-contains-stacktrace-expected.txt [modify] https://crrev.com/6d1e7a0c7e9257bff65c15ff4c2161ea448f8751/third_party/WebKit/LayoutTests/http/tests/inspector/stacktraces/csp-setTimeout-warning-contains-stacktrace-expected.txt [modify] https://crrev.com/6d1e7a0c7e9257bff65c15ff4c2161ea448f8751/third_party/WebKit/LayoutTests/inspector/console/console-log-in-xhtml-expected.txt [modify] https://crrev.com/6d1e7a0c7e9257bff65c15ff4c2161ea448f8751/third_party/WebKit/LayoutTests/inspector/console/console-log-syntax-error-expected.txt [modify] https://crrev.com/6d1e7a0c7e9257bff65c15ff4c2161ea448f8751/third_party/WebKit/Source/devtools/front_end/bindings/PresentationConsoleMessageHelper.js [modify] https://crrev.com/6d1e7a0c7e9257bff65c15ff4c2161ea448f8751/third_party/WebKit/Source/devtools/front_end/console/ConsoleView.js [modify] https://crrev.com/6d1e7a0c7e9257bff65c15ff4c2161ea448f8751/third_party/WebKit/Source/devtools/front_end/console/ConsoleViewMessage.js [modify] https://crrev.com/6d1e7a0c7e9257bff65c15ff4c2161ea448f8751/third_party/WebKit/Source/devtools/front_end/sdk/ConsoleModel.js [modify] https://crrev.com/6d1e7a0c7e9257bff65c15ff4c2161ea448f8751/third_party/WebKit/Source/devtools/front_end/sdk/RuntimeModel.js [modify] https://crrev.com/6d1e7a0c7e9257bff65c15ff4c2161ea448f8751/third_party/WebKit/Source/devtools/front_end/snippets/ScriptSnippetModel.js
Comment 1 by bugdroid1@chromium.org
, Jul 9 2016