New issue
Advanced search Search tips

Issue 591490 link

Starred by 1 user
Status: Fixed
Owner:
fgor...@chromium.org
Closed: Mar 2016
Components:
EstimatedDays: ----
NextAction: ----
OS: All
Pri: 2
Type: Bug



Sign in to add a comment

When heartbeat ack is received hearbeat interval is stuck in heartbeat ack mode.

Project Member Reported by fgor...@chromium.org, Mar 2 2016 
When heartbeat ack is received hearbeat interval is stuck in heartbeat ack mode. This causes the heartbeat to be sent every minute instead of respecting the client heartbeat interval.

See b/27382234 as well for more details.
Project Member

Comment 1 by bugdroid1@chromium.org, Mar 3 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/a565abf9111511c13ebd0809656e12323956a4b2

commit a565abf9111511c13ebd0809656e12323956a4b2
Author: fgorski <fgorski@chromium.org>
Date: Thu Mar 03 21:35:20 2016

[GCM] Fixing the client interval interaction with heartbeat ack

This patch fixes the case, where heartbeat interval is lowered to
1 minute after a heartbeat is initiated by the gcm client.

It also handles the case, where custom interval was set to a higher
value, but because of no reconnection, we are keeping the lowest
known value. (Caught by existing unit test).

BUG= 591490 
R=zea@chromium.org

Review URL: https://codereview.chromium.org/1758573004

Cr-Commit-Position: refs/heads/master@{#379095}

[modify] https://crrev.com/a565abf9111511c13ebd0809656e12323956a4b2/google_apis/gcm/engine/heartbeat_manager.cc
[modify] https://crrev.com/a565abf9111511c13ebd0809656e12323956a4b2/google_apis/gcm/engine/heartbeat_manager.h
[modify] https://crrev.com/a565abf9111511c13ebd0809656e12323956a4b2/google_apis/gcm/engine/heartbeat_manager_unittest.cc

Comment 2 by fgor...@chromium.org, Mar 3 2016

Status: Fixed (was: Assigned)
►

Sign in to add a comment