New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 591488 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Last visit > 30 days ago
Closed: Mar 2016
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug



Sign in to add a comment

Compile failure on Win8 bot

Project Member Reported by dim...@chromium.org, Mar 2 2016

Issue description

Project Member

Comment 2 by bugdroid1@chromium.org, Mar 2 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/f0444bfd6b3c6b43f34da7709debdbc248395ef5

commit f0444bfd6b3c6b43f34da7709debdbc248395ef5
Author: dimich <dimich@chromium.org>
Date: Wed Mar 02 21:40:53 2016

Revert of IPC::ParamTraits for ui::Event (towards ui::Events over mojo IPC) (patchset #17 id:320001 of https://codereview.chromium.org/1695783002/ )

Reason for revert:
It broke compile on: https://build.chromium.org/p/chromium.win/builders/Win8%20GN%20%28dbg%29

BUG= 591488 

Original issue's description:
> Implements and tests IPC::ParamTraits for ui::Event (towards ui::Events over mojo IPC). Support for (scoped) pointers for abstract ui::Event objects implemented using ui::ScopedEvent, and trusting ui::EventType information to instantiate the correct concrete type.
>
> BUG= 584687 
>
> Committed: https://crrev.com/482ddfefe2602f440146eebf4b56e8e040fb81fa
> Cr-Commit-Position: refs/heads/master@{#378821}

TBR=rockot@chromium.org,sadrul@chromium.org,kenrb@chromium.org,tsepez@chromium.org,jam@chromium.org,sky@chromium.org,markdittmer@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG= 584687 

Review URL: https://codereview.chromium.org/1755703004

Cr-Commit-Position: refs/heads/master@{#378838}

[modify] https://crrev.com/f0444bfd6b3c6b43f34da7709debdbc248395ef5/components/mus/DEPS
[modify] https://crrev.com/f0444bfd6b3c6b43f34da7709debdbc248395ef5/components/mus/common/BUILD.gn
[delete] https://crrev.com/73513876700397ec4da77edcb929537a235a2a05/components/mus/common/event_param_traits.cc
[delete] https://crrev.com/73513876700397ec4da77edcb929537a235a2a05/components/mus/common/event_param_traits.h
[delete] https://crrev.com/73513876700397ec4da77edcb929537a235a2a05/components/mus/common/event_param_traits_macros.h
[delete] https://crrev.com/73513876700397ec4da77edcb929537a235a2a05/components/mus/common/event_param_traits_unittest.cc
[delete] https://crrev.com/73513876700397ec4da77edcb929537a235a2a05/components/mus/common/mus_ipc_export.h
[modify] https://crrev.com/f0444bfd6b3c6b43f34da7709debdbc248395ef5/ui/events/event.cc
[modify] https://crrev.com/f0444bfd6b3c6b43f34da7709debdbc248395ef5/ui/events/event.h
[modify] https://crrev.com/f0444bfd6b3c6b43f34da7709debdbc248395ef5/ui/events/events.gyp
[modify] https://crrev.com/f0444bfd6b3c6b43f34da7709debdbc248395ef5/ui/events/gesture_event_details.h
[modify] https://crrev.com/f0444bfd6b3c6b43f34da7709debdbc248395ef5/ui/events/ipc/BUILD.gn
[modify] https://crrev.com/f0444bfd6b3c6b43f34da7709debdbc248395ef5/ui/events/keycodes/dom/dom_key.h
[modify] https://crrev.com/f0444bfd6b3c6b43f34da7709debdbc248395ef5/ui/gfx/ipc/gfx_param_traits.cc
[modify] https://crrev.com/f0444bfd6b3c6b43f34da7709debdbc248395ef5/ui/gfx/ipc/gfx_param_traits.h
[modify] https://crrev.com/f0444bfd6b3c6b43f34da7709debdbc248395ef5/ui/metro_viewer/metro_viewer_messages.h

Status: Fixed (was: Assigned)

Sign in to add a comment