New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 591476 link

Starred by 8 users

Issue metadata

Status: Fixed
Owner:
Closed: Sep 2016
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug
Team-Accessibility



Sign in to add a comment

High contrast accessibility extension is reliably (5 9's) resizing pages too large

Project Member Reported by pdr@chromium.org, Mar 2 2016

Issue description

A user on chromium-discuss@ reported that their pages are sized to 999999px * 999999px and it looks like this is caused by the high contrast extension written by google. This extension is used by a huge number of people and the reviews show that this is a pretty big (har har...) issue.

Extension:
https://chrome.google.com/webstore/detail/high-contrast/djcfdncoelnlbldjfhinnjlhdjlikmph

Forum post:
https://groups.google.com/a/chromium.org/d/msg/chromium-discuss/hRmIDn6jp94/rM4CURmiBwAJ

@aboxhall, can you route this to the right folks?
 

Comment 1 by pdr@chromium.org, Mar 2 2016

Cc: -dmazz...@chromium.org
Owner: dmazz...@chromium.org
Status: Assigned (was: Untriaged)
I found this is actually in our repo. Re-assigning to the correct owner.
Components: -IO>Accessibility
Components: UI>Accessibility
Fix pushed in High Contrast extension version 0.9.1

Cc: nyerramilli@chromium.org ashej...@chromium.org dmazz...@chromium.org
 Issue 568074  has been merged into this issue.
 Issue 582532  has been merged into this issue.
Cc: rnimmagadda@chromium.org roc...@chromium.org
 Issue 560008  has been merged into this issue.
Cc: kavvaru@chromium.org durga.behera@chromium.org brajkumar@chromium.org ajha@chromium.org
 Issue 537587  has been merged into this issue.
 Issue 582534  has been merged into this issue.
Status: Fixed (was: Assigned)
Project Member

Comment 12 by bugdroid1@chromium.org, Mar 28 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/adaaccd59252c8fb9af08fcf65e8b78f25f053b2

commit adaaccd59252c8fb9af08fcf65e8b78f25f053b2
Author: dmazzoni <dmazzoni@chromium.org>
Date: Tue Mar 28 17:36:45 2017

Fix High Contrast extension

Chrome 45+ doesn't let you set a filter on the HTML element anymore,
so we have to create a separate element with low z-index and copy the
background.

In addition, the filter seems to need to be fixed-positioned or Chrome
won't properly update it.

BUG= 534971 ,  591476 
NOTRY=true

Review-Url: https://codereview.chromium.org/2769743005
Cr-Commit-Position: refs/heads/master@{#460158}

[delete] https://crrev.com/010bed54423a428a1812dfe7eab7ed95c5bf9982/ui/accessibility/extensions/highcontrast/highcontrast.css
[modify] https://crrev.com/adaaccd59252c8fb9af08fcf65e8b78f25f053b2/ui/accessibility/extensions/highcontrast/highcontrast.js
[modify] https://crrev.com/adaaccd59252c8fb9af08fcf65e8b78f25f053b2/ui/accessibility/extensions/highcontrast/manifest.json

Sign in to add a comment