New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 591471 link

Starred by 1 user

Issue metadata

Status: Verified
Owner:
Closed: Mar 2016
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 1
Type: Bug



Sign in to add a comment

cq is not publishing prebuilts

Project Member Reported by akes...@chromium.org, Mar 2 2016

Issue description

Upon some investigation, it seems that the CQ has not been publishing prebuilts since around October 30. Smoking gun:

~/chromiumos/src/private-overlays/chromeos-partner-overlay/chromeos/binhost/target$ git log lumpy-PREFLIGHT_BINHOST.conf

Reveals that this file was last touched on Oct 30.

Other smoking gun:
In recent MasterUploadPrebuilts stages, you can see that it is locally updating the prebuilds from R48-7597.0.0-rc3 (!) to R51-7998.0.0-rc3


 
CommitQueueCompletion and PublishUprevChanges stages are both git cleaning local changes. This kills the prebuild conf file commits (created by MasterUploadPrebuilts) prior to publish.

Solution: move the MUP logic inside of PUC, to run right after clean on master builds that publish prebuilts.
Owner: akes...@chromium.org
Status: Started (was: Untriaged)
Project Member

Comment 3 by bugdroid1@chromium.org, Mar 4 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/chromite/+/cd0205aa67cd8ec6c1d98272ffb30a4ffea8f1ab

commit cd0205aa67cd8ec6c1d98272ffb30a4ffea8f1ab
Author: Aviv Keshet <akeshet@chromium.org>
Date: Thu Mar 03 17:36:06 2016

prebuilts: write binhost conf files in PublishUprev

This CL refactors MasterUploadPrebuiltsStage into a non-stage standalone
class. Instead of calling this stage prior to CompletionStage (as the CQ
currently does), the conf writing code is called in PublishUprev stage
immediately before uprev and conf commits are pushed.

This CL is a squashed version of the refactoring stack ending in
https://chromium-review.googlesource.com/#/c/330258/ plus any additional
post-refactor fixes.

BUG= chromium:591471 
TEST=cbuildbot --remote --buildbot --debug master-paladin with this CL

Change-Id: Iac3c8c9ceb6e491282e1c950c05c2718668e91b4
Reviewed-on: https://chromium-review.googlesource.com/330271
Commit-Ready: Aviv Keshet <akeshet@chromium.org>
Tested-by: Aviv Keshet <akeshet@chromium.org>
Reviewed-by: Don Garrett <dgarrett@chromium.org>
Reviewed-by: David James <davidjames@chromium.org>

[modify] https://crrev.com/cd0205aa67cd8ec6c1d98272ffb30a4ffea8f1ab/cbuildbot/builders/android_pfq_builders.py
[modify] https://crrev.com/cd0205aa67cd8ec6c1d98272ffb30a4ffea8f1ab/cbuildbot/stages/artifact_stages_unittest.py
[modify] https://crrev.com/cd0205aa67cd8ec6c1d98272ffb30a4ffea8f1ab/cbuildbot/prebuilts.py
[modify] https://crrev.com/cd0205aa67cd8ec6c1d98272ffb30a4ffea8f1ab/cbuildbot/stages/completion_stages.py
[modify] https://crrev.com/cd0205aa67cd8ec6c1d98272ffb30a4ffea8f1ab/cbuildbot/stages/completion_stages_unittest.py
[modify] https://crrev.com/cd0205aa67cd8ec6c1d98272ffb30a4ffea8f1ab/cbuildbot/prebuilts_unittest.py
[modify] https://crrev.com/cd0205aa67cd8ec6c1d98272ffb30a4ffea8f1ab/cbuildbot/builders/simple_builders.py
[modify] https://crrev.com/cd0205aa67cd8ec6c1d98272ffb30a4ffea8f1ab/cbuildbot/stages/artifact_stages.py

Status: Fixed (was: Started)
Labels: VerifyIn-51

Comment 6 by benhenry@google.com, Apr 27 2016

Components: Infra>Client>ChromeOS
Labels: -Infra-ChromeOS
Status: Verified (was: Fixed)
Bulk verified

Sign in to add a comment