New issue
Advanced search Search tips

Issue 591458 link

Starred by 1 user

Issue metadata

Status: Verified
Owner: ----
Closed: Mar 2016
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: ----
Type: ----

Blocking:
issue 591479



Sign in to add a comment

Create chromium/src/testing/libfuzzer repository

Project Member Reported by aizatsky@chromium.org, Mar 2 2016

Issue description

Libfuzzer is becoming a piece of important testing infrastructure and it used across multiple chromium sub-repositories. 

We need a separate git repository to allow projects to pull it via DEPS file.

chromium/src/testing/libfuzzer.git sounds like a good fit.
 

Comment 1 by kcc@chromium.org, Mar 2 2016

Cc: mmoroz@chromium.org och...@chromium.org infe...@chromium.org
Cc: kjlubick@chromium.org
Blocking: -539572 591479
Created the repo. Please let me know if you'd like to get any further ACLs set up.

git clone https://chromium.googlesource.com/chromium/src/testing/libfuzzer
Please add me (aizatsky@chromium.org) to ACLs. I can't set it up b/c I'm not a committer.
Is this a dup of issue 591259?
I don't believe so. This request is for a git repo for a dir that's part of chromium, while issue 591259 is requesting a git mirror for a subdir of the llvm project.
Ah ok. I'll add aizatsky to the acls
Actually.. I think maybe something got lost in translation. I think that this was supposed to be a subtree mirror of https://chromium.googlesource.com/chromium/src/+/master/testing/libfuzzer/ right? Or did you actually want it to be an independent repo?

Right now everything under chromium/src/* is a subtree mirror of some subdirectory of chromium/src.git. If you're OK with this (i.e. doing development work in chromium/src and then having that automatically be copied out to the subtree mirror), I can fix this to be a proper subtree mirror.
What we need to eventually accomplish is to have everything under /testing/libfuzzer moved to this new repo and have chromium (and other projects as well) pull it through DEPS. All changes to /testing/libfuzzer should go to the new repo.

We probably need a subtree mirror. I didn't know you can help me with that. I was going to wrestle with git and do it manually and update DEPS in the chrome.

If there's an easier way to do thus, it would be awesome. 

Yes, we have the capability of making it so that this git repo precisely mirrors the content of that subdirectory in the main repo. If that's what you want, I can get that working in a couple minutes.
So to be super clear. There are two options:
  1) Make a new repo (somewhere else than /chromium/src/testing/libfuzzer, probably a top level /libfuzzer repo), and DEPS that into /chromium/src. New changes would go into /libfuzzer.
  2) Make a subtree repo (at /chromium/src/testing/libfuzzer) which mirrors the content of that subdirectory of /chromium/src automatically. New changes will continue to go into /chromium/src.

Right now we're in a hybrid state.
FWIW, there any many such subtree repos already under chromium/src/*, and they all work in the "chromium repo first" model (e.g. CLs land in chromium and gets mirrored to subtrees). You want to do it in an opposite way (CLs land in separate repo and gets DEPSed in chromium). I believe having two kinds of repos under chromium/src/* prefix increases confusion. If libfuzzer is being split into separate independent lib that's DEPSed in Chromium, better host it elsewhere, e.g. git clone https://chromium.googlesource.com/chromium/libfuzzer/libfuzzer.

(Feel free to ignore this comment, it's minor concern in a grand scheme of things)
Right, that's what I'm trying to address here :)

It was decided offline to make it a subtree mirror. It should have content shortly.
Status: Fixed (was: Untriaged)
done :) https://chromium.googlesource.com/chromium/src/testing/libfuzzer/
Labels: -Stability-Libfuzzer LibFuzzer-Infra
Labels: VerifyIn-51
Components: Infra>Git
Labels: -Infra-Git
Status: Verified (was: Fixed)
Bulk verified

Sign in to add a comment