New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 591453 link

Starred by 3 users

Issue metadata

Status: Verified
Owner:
Closed: Nov 2016
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 1
Type: Bug
Team-Accessibility



Sign in to add a comment

ChromeVox not switching to correct languge

Project Member Reported by kathrelk...@chromium.org, Mar 2 2016

Issue description

48.0.2564.116

What steps will reproduce the problem?
1. Use the settings page to set the Chromebook's language to Spanish and display Chrome in that language.
2. Sign out and back in to complete the change.
3. Enable ChromeVox.

What is the expected output? What do you see instead?
Expect that ChromeVox uses the Spanish voice.

Instead, the welcome message is displayed in Spanish, but any following text is spoken in the German voice.  Problem was reproducible.
 

Comment 1 Deleted

Comment 2 Deleted

mndnfokpggljbaajbnioimlmbfngpief-1456948277670.log
6.4 KB View Download
Cc: -dtseng@chromium.org
Owner: dtseng@chromium.org
Status: Assigned (was: Untriaged)
Triage: assigning to David for further investigation 

Comment 6 by royans@chromium.org, Mar 29 2016

Cc: cyrusm@chromium.org maxkirsch@chromium.org
Labels: Hotlist-Enterprise
This has a big impact in enterprise.
Duplicated issue from a partner: https://crosbug.com/p/53800
Project Member

Comment 8 by bugdroid1@chromium.org, Nov 22 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/c1cab294711bca021f9e21a06e9183ca88b8c62a

commit c1cab294711bca021f9e21a06e9183ca88b8c62a
Author: dtseng <dtseng@chromium.org>
Date: Tue Nov 22 02:17:37 2016

Fix language switching

Ensure we're
- querying for the user's preferred languages via
chrome.i18n.getAcceptLanguages
- matching in both directions i.e. voice.lang starts with of ui locale and ui locale starts with voice lang. For example, es, es-ES vs es-ES, es.
TEST=add Spanish as a voice and get the voice to be first in the languages and input screen (UI is somewhat inaccessible). Verify that ChromeVox, when re-started, speaks in Spanish.

Previously, we would have picked German (the last clause of the our matching predicates which just picks the first voice).
BUG= 591453 
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2506203002
Cr-Commit-Position: refs/heads/master@{#433747}

[modify] https://crrev.com/c1cab294711bca021f9e21a06e9183ca88b8c62a/chrome/browser/resources/chromeos/chromevox/host/chrome/tts_background.js
[modify] https://crrev.com/c1cab294711bca021f9e21a06e9183ca88b8c62a/chrome/browser/resources/chromeos/chromevox/host/chrome/tts_background_test.extjs

Comment 9 by dtseng@chromium.org, Nov 22 2016

Status: fixed (was: Assigned)

Comment 10 by dchan@google.com, Mar 4 2017

Labels: VerifyIn-58

Comment 11 by dchan@google.com, Apr 17 2017

Labels: VerifyIn-59
Verified in Chrome OS 9534.0.0, 60.0.3092.0
Status: Verified (was: Fixed)

Sign in to add a comment