Issue metadata
Sign in to add a comment
|
No focus styles in <video> shadow DOM |
||||||||||||||||||||||||
Issue description1. Go to https://rawgit.com/bkardell/8a1c801fb9f10468952b/raw/55e57ed53408186f52d70ee86952425275e03c08/test.html 2. Press 'tab' twice: a) The video element is focused and gets a focus highlight ring b) No element appears focused, but pressing 'enter' confirms that the play button is focused, as the video starts playing
,
Mar 23 2016
I checked Mac, Linux, Win and found on Linux/Win focus highlight ring is drawn around play button (the contrast is low and not much visible, but it's a different issue), but on Mac focus highlight ring is not visible.
,
Mar 23 2016
In <video>'s UA shadow, specifically, <input type="button" pseudo="-webkit-media-controls-play-button"> (and others, like sliders) doesn't render focus ring around on Mac. tkent-san, could you take a look?
,
Mar 23 2016
I think this is a bug of LayoutThemeMac::themeDrawsFocusRing. This function should return false for media appearance values.
,
Mar 23 2016
,
Mar 23 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/bccaa6b939b3daed06d54bd99ffb1c9e24e5a8b4 commit bccaa6b939b3daed06d54bd99ffb1c9e24e5a8b4 Author: tkent <tkent@chromium.org> Date: Wed Mar 23 11:19:43 2016 OSX: Media appearance values don't support native focus ring. BUG= 591451 Review URL: https://codereview.chromium.org/1829513003 Cr-Commit-Position: refs/heads/master@{#382830} [modify] https://crrev.com/bccaa6b939b3daed06d54bd99ffb1c9e24e5a8b4/third_party/WebKit/LayoutTests/TestExpectations [add] https://crrev.com/bccaa6b939b3daed06d54bd99ffb1c9e24e5a8b4/third_party/WebKit/LayoutTests/media/controls-focus-ring.html [add] https://crrev.com/bccaa6b939b3daed06d54bd99ffb1c9e24e5a8b4/third_party/WebKit/LayoutTests/platform/mac/media/controls-focus-ring-expected.png [add] https://crrev.com/bccaa6b939b3daed06d54bd99ffb1c9e24e5a8b4/third_party/WebKit/LayoutTests/platform/mac/media/controls-focus-ring-expected.txt [modify] https://crrev.com/bccaa6b939b3daed06d54bd99ffb1c9e24e5a8b4/third_party/WebKit/Source/core/layout/LayoutThemeMac.mm
,
Mar 23 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/f6efbd74a1ac597f61ead530f9123f465c0c139e commit f6efbd74a1ac597f61ead530f9123f465c0c139e Author: Rebaseline Bot <blink-rebaseline-bot@chromium.org> Date: Wed Mar 23 13:07:26 2016 Auto-rebaseline for r382830 https://chromium.googlesource.com/chromium/src/+/bccaa6b93 BUG= 591451 TBR=tkent@chromium.org Review URL: https://codereview.chromium.org/1830553002 . Cr-Commit-Position: refs/heads/master@{#382840} [modify] https://crrev.com/f6efbd74a1ac597f61ead530f9123f465c0c139e/third_party/WebKit/LayoutTests/TestExpectations [add] https://crrev.com/f6efbd74a1ac597f61ead530f9123f465c0c139e/third_party/WebKit/LayoutTests/platform/linux/media/controls-focus-ring-expected.png [add] https://crrev.com/f6efbd74a1ac597f61ead530f9123f465c0c139e/third_party/WebKit/LayoutTests/platform/linux/media/controls-focus-ring-expected.txt [add] https://crrev.com/f6efbd74a1ac597f61ead530f9123f465c0c139e/third_party/WebKit/LayoutTests/platform/win/media/controls-focus-ring-expected.png [add] https://crrev.com/f6efbd74a1ac597f61ead530f9123f465c0c139e/third_party/WebKit/LayoutTests/platform/win/media/controls-focus-ring-expected.txt
,
Mar 23 2016
,
Jul 28 2016
Moving component:Internals>Media>Controls to Blink>Media>Controls |
|||||||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||||||
Comment 1 by sshru...@google.com
, Mar 21 2016