UrlRequestMetrics#getSentBytesCount() always returns null |
||||||||||||
Issue descriptionSteps to reproduce the problem: 1. Create a CronetEngine and call enableNetworkQualityEstimator followed by addRequestFinishedListener. 2. Create and send a UrlRequest. 3. In your RequestFinishedListener#onRequestFinished(UrlRequestInfo), UrlRequestInfo.getMetrics().getSendBytesCount() will always return null. What is the expected behavior? UrlRequestInfo.getMetrics().getSendBytesCount() should return the total amount of data sent over the network. What went wrong? CronetUrlRequest does not expose sendBytesCount from the underlying URLRequest: https://code.google.com/p/chromium/codesearch#chromium/src/components/cronet/android/java/src/org/chromium/net/CronetUrlRequest.java&l=692 https://code.google.com/p/chromium/codesearch#chromium/src/net/url_request/url_request.h&l=401 Did this work before? No Chrome version: 48.0.2564.116 Channel: canary OS Version: Flash Version: Shockwave Flash 20.0 r0
,
Apr 5 2016
,
Apr 5 2016
Not sure who really owns this, just expanding the CC list in case it's you guys.
,
Apr 6 2016
The experimental UrlRequestMetrics API was added by klm@, and will likely be owned by mgersh@.
,
Apr 26 2016
,
Jun 3 2016
,
Jun 14 2016
,
Jul 18 2016
,
Jul 18 2016
,
Jul 18 2016
,
Oct 5 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/06763af4b30a9a7b8e1a190d9f2493f9467cab67 commit 06763af4b30a9a7b8e1a190d9f2493f9467cab67 Author: mgersh <mgersh@chromium.org> Date: Wed Oct 05 21:04:56 2016 Implement getSentBytesCount() in Cronet UrlRequest metrics BUG= 591434 , 629194 Review-Url: https://codereview.chromium.org/2391423002 Cr-Commit-Position: refs/heads/master@{#423287} [modify] https://crrev.com/06763af4b30a9a7b8e1a190d9f2493f9467cab67/components/cronet/android/cronet_url_request_adapter.cc [modify] https://crrev.com/06763af4b30a9a7b8e1a190d9f2493f9467cab67/components/cronet/android/test/javatests/src/org/chromium/net/QuicTest.java [modify] https://crrev.com/06763af4b30a9a7b8e1a190d9f2493f9467cab67/components/cronet/android/test/javatests/src/org/chromium/net/RequestFinishedInfoTest.java
,
Oct 27 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/06763af4b30a9a7b8e1a190d9f2493f9467cab67 commit 06763af4b30a9a7b8e1a190d9f2493f9467cab67 Author: mgersh <mgersh@chromium.org> Date: Wed Oct 05 21:04:56 2016 Implement getSentBytesCount() in Cronet UrlRequest metrics BUG= 591434 , 629194 Review-Url: https://codereview.chromium.org/2391423002 Cr-Commit-Position: refs/heads/master@{#423287} [modify] https://crrev.com/06763af4b30a9a7b8e1a190d9f2493f9467cab67/components/cronet/android/cronet_url_request_adapter.cc [modify] https://crrev.com/06763af4b30a9a7b8e1a190d9f2493f9467cab67/components/cronet/android/test/javatests/src/org/chromium/net/QuicTest.java [modify] https://crrev.com/06763af4b30a9a7b8e1a190d9f2493f9467cab67/components/cronet/android/test/javatests/src/org/chromium/net/RequestFinishedInfoTest.java
,
Nov 4 2016
[Automated comment] removing mislabelled merge-merged-2840
,
Nov 7 2016
|
||||||||||||
►
Sign in to add a comment |
||||||||||||
Comment 1 by mef@chromium.org
, Mar 2 2016Status: Available (was: Unconfirmed)