Issue metadata
Sign in to add a comment
|
Make perf trybot run command bails out early if the benchmark is disabled on specified trybot |
||||||||||||||||||||||||
Issue descriptionFor simple case in which a telemetry benchmark is disabled on a specific platform and user want to run on a trybot of that platform, the command should let user know and bails out early instead of sending the command to the bot.
,
Mar 10 2016
,
Mar 10 2016
,
Apr 7 2016
,
Apr 7 2016
Robert@ got bitten by this today. I will try to make a CL...
,
Apr 7 2016
+1. I just got burned here with multiple hours of builds just to find out the benchmark is disabled.
,
Apr 7 2016
,
Apr 11 2016
,
Apr 11 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/1f209bc5e1f049ca2dad7ca1145a34332e3f27d7 commit 1f209bc5e1f049ca2dad7ca1145a34332e3f27d7 Author: nednguyen <nednguyen@google.com> Date: Mon Apr 11 18:16:47 2016 [tools/perf] Make trybot bails out early if the benchmark is disabled on trybot platform Note that this functionality only work to some certain extent since the disabling can be very dynamic & requires the actual hardware to know whether the benchmark is actually disabled. We bias on the side of not disabling the benchmark if we don't have enough information to tell & add a warning message telling users that the benchmark may be disabled. BUG= 591410 Review URL: https://codereview.chromium.org/1873623002 Cr-Commit-Position: refs/heads/master@{#386410} [modify] https://crrev.com/1f209bc5e1f049ca2dad7ca1145a34332e3f27d7/tools/perf/core/trybot_command.py [modify] https://crrev.com/1f209bc5e1f049ca2dad7ca1145a34332e3f27d7/tools/perf/core/trybot_command_unittest.py
,
Apr 11 2016
Should be fixed, feel free to reopen. |
|||||||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||||||
Comment 1 by sullivan@chromium.org
, Mar 2 2016