Make perf trybot run command bails out early if the benchmark name is not recognizable |
||||
Issue descriptionTypo when specifying which benchmark to run is a common mistake users have when running the trybot command. The command should bail out early & notify clients if the benchmark they want to run does not exist & show the approximate suggestions. Not only this improve user experience, it also reduce the unnecessary load on the perfbot.
,
Mar 2 2016
,
Mar 3 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/00068d02c120dcfbf6cae98ff949c627a3762883 commit 00068d02c120dcfbf6cae98ff949c627a3762883 Author: nednguyen <nednguyen@google.com> Date: Thu Mar 03 01:05:28 2016 [tools/perf] Raise parser error if trybot command failed to find a matching benchmark After this: tools/perf/run_benchmark try linux octanez usage: Run telemetry benchmarks on trybot. You can add all the benchmark options available except the --browser option [-h] <trybot name> <benchmark name> Run telemetry benchmarks on trybot. You can add all the benchmark options available except the --browser option: error: No benchmark named "octanez". Do you mean any of those benchmarks below? octane oortonline BUG= 591409 Review URL: https://codereview.chromium.org/1757773003 Cr-Commit-Position: refs/heads/master@{#378901} [modify] https://crrev.com/00068d02c120dcfbf6cae98ff949c627a3762883/tools/perf/core/trybot_command.py [modify] https://crrev.com/00068d02c120dcfbf6cae98ff949c627a3762883/tools/perf/scripts_smoke_unittest.py
,
Mar 3 2016
,
Mar 9 2016
|
||||
►
Sign in to add a comment |
||||
Comment 1 by nedngu...@google.com
, Mar 2 2016Status: Started (was: Untriaged)