MediaRecorderHandlerTest.EncodeAudioFrames and related tests failing on Win Clang TOT bots |
|||
Issue descriptionThis is over LLVM revision range 262315:262457. The pinned bots are not failing, so I suspect this is an LLVM issue.
,
Mar 2 2016
I strongly suspect our chkstk change. This failure appears to only affect 32-bit bots. We don't use inalloca on x64.
,
Mar 2 2016
,
Mar 2 2016
Issue 591437 has been merged into this issue.
,
Mar 2 2016
Pretty sure we crashed here: https://code.google.com/p/chromium/codesearch#chromium/src/third_party/opus/src/src/analysis.c&l=262 ALLOC(in, 480, kiss_fft_cpx); ALLOC(out, 480, kiss_fft_cpx); ALLOC(tonality, 240, float); ALLOC(noisiness, 240, float); Together, the allocations require probing, but each individual allocation is less than 4096 bytes. There would be no bug if these were part of a call sequence, because the call always touches the top of the stack. So, we could limit our optimization to inalloca allocations, or revert and try to be more sophisticated later.
,
Mar 2 2016
Reverted in r262505. We can get better code size savings if we tackle this problem a different way. |
|||
►
Sign in to add a comment |
|||
Comment 1 by h...@chromium.org
, Mar 2 2016