New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 591404 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner: ----
Closed: Mar 2016
Cc:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug

Blocking:
issue 589647



Sign in to add a comment

MediaRecorderHandlerTest.EncodeAudioFrames and related tests failing on Win Clang TOT bots

Project Member Reported by r...@chromium.org, Mar 2 2016

Issue description

This is over LLVM revision range 262315:262457. The pinned bots are not failing, so I suspect this is an LLVM issue.
 

Comment 1 by h...@chromium.org, Mar 2 2016

Slightly tighter range I think is 262315:262388

Not too much in there that could affect us
r262352 - [X86] Check that attribute parameters match for tail calls (PR26590)
r262358 - DAGCombiner: Turn extract of bitcasted integer into truncate
r262370 - [X86] Elide references to _chkstk for dynamic allocas
r262376 - Fix an issue where fast math flags were dropped during scalarization
r262379 - [MSVC Compat] Correctly handle finallys nested within finallys

Comment 2 by r...@chromium.org, Mar 2 2016

I strongly suspect our chkstk change. This failure appears to only affect 32-bit bots. We don't use inalloca on x64.

Comment 3 by r...@chromium.org, Mar 2 2016

Cc: majnemer@chromium.org

Comment 4 by h...@chromium.org, Mar 2 2016

 Issue 591437  has been merged into this issue.

Comment 5 by r...@chromium.org, Mar 2 2016

Pretty sure we crashed here:
https://code.google.com/p/chromium/codesearch#chromium/src/third_party/opus/src/src/analysis.c&l=262
    ALLOC(in, 480, kiss_fft_cpx);
    ALLOC(out, 480, kiss_fft_cpx);
    ALLOC(tonality, 240, float);
    ALLOC(noisiness, 240, float);

Together, the allocations require probing, but each individual allocation is less than 4096 bytes. There would be no bug if these were part of a call sequence, because the call always touches the top of the stack. So, we could limit our optimization to inalloca allocations, or revert and try to be more sophisticated later.

Comment 6 by r...@chromium.org, Mar 2 2016

Status: Fixed (was: Untriaged)
Reverted in r262505. We can get better code size savings if we tackle this problem a different way.

Sign in to add a comment