New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 591399 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Last visit > 30 days ago
Closed: Mar 2016
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug



Sign in to add a comment

remove code for deprecated WebCore.Scripts.ParsingBlocking.TimeBetweenLoadedAndCompiled histogram

Project Member Reported by bmcquade@chromium.org, Mar 2 2016

Issue description

WebCore.Scripts.ParsingBlocking.TimeBetweenLoadedAndCompiled is marked as deprecated in histograms.xml however there is still code for this histogram checked in. The code has also rotted, for example, the code for this histogram depends on the state of a boolean member added to HTMLScriptRunner that's always false. We should remove the code for this histogram.
 

Comment 1 Deleted

Project Member

Comment 2 by bugdroid1@chromium.org, Mar 3 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/f1411c1e570b2e44bdd0c8a0b17a9d0aa6f901a6

commit f1411c1e570b2e44bdd0c8a0b17a9d0aa6f901a6
Author: bmcquade <bmcquade@chromium.org>
Date: Thu Mar 03 02:44:29 2016

Remove code for deprecated and rotted histogram.

WebCore.Scripts.ParsingBlocking.TimeBetweenLoadedAndCompiled is marked
as deprecated in histograms.xml (see
https://chromium.googlesource.com/chromium/src/+/68cde75708853730a1881142d330d573194dc3e4),
but we still have code checked in to report it. The code has also
rotted. For example, the code for this histogram depends on the state
of a boolean member added to HTMLScriptRunner that's always false.

BUG= 591399 

Review URL: https://codereview.chromium.org/1754213003

Cr-Commit-Position: refs/heads/master@{#378926}

[modify] https://crrev.com/f1411c1e570b2e44bdd0c8a0b17a9d0aa6f901a6/third_party/WebKit/Source/core/html/parser/HTMLScriptRunner.cpp
[modify] https://crrev.com/f1411c1e570b2e44bdd0c8a0b17a9d0aa6f901a6/third_party/WebKit/Source/core/html/parser/HTMLScriptRunner.h

Status: Fixed (was: Started)
Project Member

Comment 4 by bugdroid1@chromium.org, Mar 3 2016

Labels: merge-merged-2666
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/f1411c1e570b2e44bdd0c8a0b17a9d0aa6f901a6

commit f1411c1e570b2e44bdd0c8a0b17a9d0aa6f901a6
Author: bmcquade <bmcquade@chromium.org>
Date: Thu Mar 03 02:44:29 2016

Remove code for deprecated and rotted histogram.

WebCore.Scripts.ParsingBlocking.TimeBetweenLoadedAndCompiled is marked
as deprecated in histograms.xml (see
https://chromium.googlesource.com/chromium/src/+/68cde75708853730a1881142d330d573194dc3e4),
but we still have code checked in to report it. The code has also
rotted. For example, the code for this histogram depends on the state
of a boolean member added to HTMLScriptRunner that's always false.

BUG= 591399 

Review URL: https://codereview.chromium.org/1754213003

Cr-Commit-Position: refs/heads/master@{#378926}

[modify] https://crrev.com/f1411c1e570b2e44bdd0c8a0b17a9d0aa6f901a6/third_party/WebKit/Source/core/html/parser/HTMLScriptRunner.cpp
[modify] https://crrev.com/f1411c1e570b2e44bdd0c8a0b17a9d0aa6f901a6/third_party/WebKit/Source/core/html/parser/HTMLScriptRunner.h

Sign in to add a comment