New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 591338 link

Starred by 2 users
Status: Verified
Owner:
█ yunlian@chromium.org
Last visit > 30 days ago
Closed: Mar 2016
Cc:
abodenha@chromium.org
cywang@chromium.org
vapier@chromium.org
█ charliemooney@chromium.org
█ bccheng@chromium.org
█ lpique@chromium.org
█ bfreed@chromium.org
saintlou@google.com
josa...@google.com
puneetster@google.com
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 0
Type: Bug



Sign in to add a comment

ChromeSDK stage fails with "clang: error: unknown argument: '-freorder-functions=callgraph'"

Project Member Reported by hashimoto@chromium.org, Mar 2 2016 
Recently, Chrome PFQ bots are failing in ChromeSDK stage with the following error.

[143/23019] LINK genversion
FAILED: /b/cbuild/internal_master/.cache/distfiles/target/chrome-src/src/third_party/llvm-build/Release+Asserts/bin/clang -Wl,-O1 -Wl,-O2 -Wl,--as-needed -freorder-functions=callgraph -Wl,-rosegment -Wl,--plugin-opt,split_segment=yes -Wl,-z,now -Wl,-z,relro -Wl,-z,defs -pthread -Wl,-z,noexecstack -fPIC -fuse-ld=gold -Wl,--disable-new-dtags -Wl,-O1 -Wl,--as-needed -Wl,--gc-sections -o genversion -Wl,--start-group obj.host/third_party/yasm/source/patched-yasm/modules/preprocs/nasm/genversion.genversion.o -Wl,--end-group  
clang: error: unknown argument: '-freorder-functions=callgraph'
ninja: build stopped: subcommand failed.

shenhan@, is there any chance this is related to your change (https://chromium-review.googlesource.com/#/c/328271/)?

Comment 1 by yunlian@chromium.org, Mar 2 2016

Cc: vapier@chromium.org
Labels: Build-Toolchain
Owner: yunlian@chromium.org
This is because ChromeSDK does not use the flags from chrome ebuild properly.

In my CL https://chromium-review.googlesource.com/#/c/328534/, it only adds these flags when we use gcc to build it. However, the ChromeSDK adds these flags to clang.
Project Member

Comment 2 by bugdroid1@chromium.org, Mar 2 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/overlays/chromiumos-overlay/+/e69171ae559d570fdaf2f2681be731d8ecb134f0

commit e69171ae559d570fdaf2f2681be731d8ecb134f0
Author: Yunlian Jiang <yunlian@chromium.org>
Date: Wed Mar 02 17:47:50 2016

This break PFQ,  crbug.com/591338 
Revert "chormeos-chrome: add flags to separate hot text sections."

This reverts commit d2d96ed0d77b4c73936b6b1c5dacd4580d7517c9.

BUG= chromium:591338 

Change-Id: I2c16f38c61aec10349bce0604ad7aaa7ebfb7abf
Reviewed-on: https://chromium-review.googlesource.com/330120
Reviewed-by: Luis Lozano <llozano@chromium.org>
Commit-Queue: Yunlian Jiang <yunlian@chromium.org>
Tested-by: Yunlian Jiang <yunlian@chromium.org>

[modify] https://crrev.com/e69171ae559d570fdaf2f2681be731d8ecb134f0/chromeos-base/chromeos-chrome/chromeos-chrome-9999.ebuild

Comment 3 by ihf@chromium.org, Mar 2 2016

Cc: cywang@chromium.org charliemooney@chromium.org bfreed@chromium.org bccheng@chromium.org lpique@chromium.org
 Issue 591308  has been merged into this issue.

Comment 4 by yunlian@chromium.org, Mar 3 2016

Status: Verified (was: Assigned)
►

Sign in to add a comment