Regression: Unnecessary current profile name is seen in context menu of any link button.
Reported by
vvishwak...@etouch.net,
Mar 2 2016
|
||||
Issue descriptionVersion: 51.0.2665.0 (Official Build) canary c5656532d43869dab92268b04fdc4d57f8a96c88-refs/heads/master@{#378647} (32/64-bit) OS: All (Win 7-Aero enabled) What steps will reproduce the problem? 1) Launch chrome, go to chrome://settings and add two users (eg. Person 2 and Person 3). 2) Now to any link, right click select 'Open link as' option and observe. Current profile name (Person 1) is also seen under 'Open link as' option. Current profile name (Person 1) should not be seen as we have 'Open link in New tab' and 'Open link in New window' options in context menu. This is a Regression issue broken in M-51, below is the bisect info Good build: 51.0.2663.0 Bad build: 51.0.2664.0 Narrow bisect URL: https://chromium.googlesource.com/chromium/src/+log/beab086f2531fb71d06b49ee23da38fa80fb0584..4e254a6cef98f089a02123d32a22672b3e900aa7?pretty=fuller&n=100 Suspecting: r378323
,
Mar 3 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/4c18bd250544470fff99ae1d9b631742d94a2983 commit 4c18bd250544470fff99ae1d9b631742d94a2983 Author: lwchkg <lwchkg@gmail.com> Date: Thu Mar 03 11:54:14 2016 Fix current profile is unnecessary added to "Open link as" context menu. The CL which introduced the bug is https://crrev.com/378323 This CL also updated a few tests for check for regressions of the same type. BUG= 591331 TEST=pass the browser tests in this CL Review URL: https://codereview.chromium.org/1754393002 Cr-Commit-Position: refs/heads/master@{#378999} [modify] https://crrev.com/4c18bd250544470fff99ae1d9b631742d94a2983/chrome/browser/renderer_context_menu/render_view_context_menu.cc [modify] https://crrev.com/4c18bd250544470fff99ae1d9b631742d94a2983/chrome/browser/renderer_context_menu/render_view_context_menu_browsertest.cc [modify] https://crrev.com/4c18bd250544470fff99ae1d9b631742d94a2983/chrome/browser/renderer_context_menu/render_view_context_menu_test_util.cc [modify] https://crrev.com/4c18bd250544470fff99ae1d9b631742d94a2983/chrome/browser/renderer_context_menu/render_view_context_menu_test_util.h
,
Mar 3 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/4c18bd250544470fff99ae1d9b631742d94a2983 commit 4c18bd250544470fff99ae1d9b631742d94a2983 Author: lwchkg <lwchkg@gmail.com> Date: Thu Mar 03 11:54:14 2016 Fix current profile is unnecessary added to "Open link as" context menu. The CL which introduced the bug is https://crrev.com/378323 This CL also updated a few tests for check for regressions of the same type. BUG= 591331 TEST=pass the browser tests in this CL Review URL: https://codereview.chromium.org/1754393002 Cr-Commit-Position: refs/heads/master@{#378999} [modify] https://crrev.com/4c18bd250544470fff99ae1d9b631742d94a2983/chrome/browser/renderer_context_menu/render_view_context_menu.cc [modify] https://crrev.com/4c18bd250544470fff99ae1d9b631742d94a2983/chrome/browser/renderer_context_menu/render_view_context_menu_browsertest.cc [modify] https://crrev.com/4c18bd250544470fff99ae1d9b631742d94a2983/chrome/browser/renderer_context_menu/render_view_context_menu_test_util.cc [modify] https://crrev.com/4c18bd250544470fff99ae1d9b631742d94a2983/chrome/browser/renderer_context_menu/render_view_context_menu_test_util.h
,
Mar 14 2016
vvishwakarma@ could you please verify the fix?
,
Mar 15 2016
With response to comment #4: Verified the above issue on Windows OS (Win 7, 8, 10 ) on latest build Chrome version: 51.0.2679.0 and Mac OS Chrome version: 51.0.2678.0. The above issue is fixed and is working as intended.
,
Mar 15 2016
Thanks for the update adding TE-Verified labels as per above comment.
,
Apr 1 2016
|
||||
►
Sign in to add a comment |
||||
Comment 1 by ranjitkan@chromium.org
, Mar 2 2016