Issue metadata
Sign in to add a comment
|
Unable to see form inputs (radio/checkboxes) in device mode
Reported by
dan.warman@cultbeauty.co.uk,
Mar 2 2016
|
||||||||||||||||||||||
Issue descriptionUserAgent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10_10_5) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/51.0.2664.0 Safari/537.36 Steps to reproduce the problem: 1. Go to www.w3schools.com/html/tryit.asp?filename=tryhtml_form_radio 2. Open Developer Tools and select device mode 3. Refresh and you'll see that the inputs have a heigh/width of 0 and are not visible. What is the expected behavior? Visible inputs What went wrong? I am unable to see form inputs, specifically radio and checkboxes, in Chrome Canary (Version 51.0.2664.0 canary (64-bit)) whilst in device mode. For example, a screenshot of this url has been attached: www.w3schools.com/html/tryit.asp?filename=tryhtml_form_radio Did this work before? N/A Chrome version: 51.0.2664.0 Channel: n/a OS Version: OS X 10.10.5 Flash Version: Shockwave Flash 21.0 r0
,
Mar 2 2016
Same issue. Is there anything I can check or provide to help you replicate this?
,
Mar 2 2016
Could be something Mac-specific going on... Assigning to dgozman to triage further since he handles most of the Device Mode stuff.
,
Apr 4 2016
,
Apr 5 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/9f52d372f849394e43bb2e648750311442a029e3 commit 9f52d372f849394e43bb2e648750311442a029e3 Author: dgozman <dgozman@chromium.org> Date: Tue Apr 05 17:22:48 2016 Use fallback in LayoutThemeMobile on mac. WebThemeEngine does nothing on mac, so we use fallback to paint radio and checkbox. This only happens when emulating mobile device on mac. BUG= 591315 Review URL: https://codereview.chromium.org/1837963002 Cr-Commit-Position: refs/heads/master@{#385205} [add] https://crrev.com/9f52d372f849394e43bb2e648750311442a029e3/third_party/WebKit/LayoutTests/inspector-protocol/emulation/device-emulation-controls-expected.txt [add] https://crrev.com/9f52d372f849394e43bb2e648750311442a029e3/third_party/WebKit/LayoutTests/inspector-protocol/emulation/device-emulation-controls.html [modify] https://crrev.com/9f52d372f849394e43bb2e648750311442a029e3/third_party/WebKit/LayoutTests/inspector-protocol/emulation/device-emulation-test.js [modify] https://crrev.com/9f52d372f849394e43bb2e648750311442a029e3/third_party/WebKit/Source/core/layout/LayoutThemeMobile.cpp [modify] https://crrev.com/9f52d372f849394e43bb2e648750311442a029e3/third_party/WebKit/Source/core/layout/LayoutThemeMobile.h
,
Apr 5 2016
,
Apr 8 2016
Verified in mac canary 51.0.2702.2, requesting merge to M50.
,
Apr 8 2016
Your change meets the bar and is auto-approved for M50 (branch: 2661)
,
Apr 8 2016
Please merge your change to M50 branch 2661 by 5:00 PM PST on April 8th,Friday to make into the desktop Stable final build cut. Thank you.
,
Apr 9 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/3b3fde3ff83fee5e6980d5a529b45ac370657877 commit 3b3fde3ff83fee5e6980d5a529b45ac370657877 Author: Dmitry Gozman <dgozman@chromium.org> Date: Sat Apr 09 00:20:39 2016 Use fallback in LayoutThemeMobile on mac. WebThemeEngine does nothing on mac, so we use fallback to paint radio and checkbox. This only happens when emulating mobile device on mac. BUG= 591315 Review URL: https://codereview.chromium.org/1837963002 Cr-Commit-Position: refs/heads/master@{#385205} (cherry picked from commit 9f52d372f849394e43bb2e648750311442a029e3) TBR=dgozman Review URL: https://codereview.chromium.org/1870173003 . Cr-Commit-Position: refs/branch-heads/2661@{#539} Cr-Branched-From: ef6f6ae5e4c96622286b563658d5cd62a6cf1197-refs/heads/master@{#378081} [add] https://crrev.com/3b3fde3ff83fee5e6980d5a529b45ac370657877/third_party/WebKit/LayoutTests/inspector-protocol/emulation/device-emulation-controls-expected.txt [add] https://crrev.com/3b3fde3ff83fee5e6980d5a529b45ac370657877/third_party/WebKit/LayoutTests/inspector-protocol/emulation/device-emulation-controls.html [modify] https://crrev.com/3b3fde3ff83fee5e6980d5a529b45ac370657877/third_party/WebKit/LayoutTests/inspector-protocol/emulation/device-emulation-test.js [modify] https://crrev.com/3b3fde3ff83fee5e6980d5a529b45ac370657877/third_party/WebKit/Source/core/layout/LayoutThemeMobile.cpp [modify] https://crrev.com/3b3fde3ff83fee5e6980d5a529b45ac370657877/third_party/WebKit/Source/core/layout/LayoutThemeMobile.h
,
Apr 9 2016
|
|||||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||||
Comment 1 by jonathan.garbee@chromium.org
, Mar 2 2016