CREDENTIAL: Android doesn't like "null" as a federation origin. |
||||||
Issue descriptionAfter https://codereview.chromium.org/1723583004, we serialize `PasswordCredential` objects with a `federation_url` of "null" (as "null" is the serialization of an empty/unique origin. Android doesn't like this. So, I suppose we need to special-case it.
,
Mar 3 2016
Hello friendly release managers. I'd like to merge this back to M50 to fix a bug with the serialization of password credentials into chrome sync. WDYT?
,
Mar 3 2016
Your change meets the bar and is auto-approved for M50 (branch: 2661)
,
Mar 3 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/0e8fd0d85b3174359835662c3dbd9f3059120729 commit 0e8fd0d85b3174359835662c3dbd9f3059120729 Author: Mike West <mkwst@google.com> Date: Thu Mar 03 09:06:41 2016 CREDENTIAL: Serialize 'PasswordCredential' objects with "" as the federation. After https://codereview.chromium.org/1723583004, we serialize `PasswordCredential` objects with a `federation_url` of "null" (as "null" is the serialization of an empty/unique origin. Neither Android nor Vasilii like this. This patch special-cases things to ensure that Android (and Vasilii) remains as happy as can be. BUG= 591310 R=vasilii@chromium.org Review URL: https://codereview.chromium.org/1755053002 Cr-Commit-Position: refs/heads/master@{#378734} (cherry picked from commit 45bf9a3d72344f1b7a6f28e0bc1c5536339db4a8) Review URL: https://codereview.chromium.org/1752383004 . Cr-Commit-Position: refs/branch-heads/2661@{#62} Cr-Branched-From: ef6f6ae5e4c96622286b563658d5cd62a6cf1197-refs/heads/master@{#378081} [modify] https://crrev.com/0e8fd0d85b3174359835662c3dbd9f3059120729/chrome/browser/password_manager/native_backend_gnome_x.cc [modify] https://crrev.com/0e8fd0d85b3174359835662c3dbd9f3059120729/chrome/browser/password_manager/native_backend_gnome_x_unittest.cc [modify] https://crrev.com/0e8fd0d85b3174359835662c3dbd9f3059120729/chrome/browser/password_manager/native_backend_kwallet_x.cc [modify] https://crrev.com/0e8fd0d85b3174359835662c3dbd9f3059120729/chrome/browser/password_manager/native_backend_libsecret.cc [modify] https://crrev.com/0e8fd0d85b3174359835662c3dbd9f3059120729/chrome/browser/password_manager/native_backend_libsecret_unittest.cc [modify] https://crrev.com/0e8fd0d85b3174359835662c3dbd9f3059120729/components/password_manager/core/browser/login_database.cc
,
Mar 3 2016
,
May 12 2016
bulk verify (M50 clean up) |
||||||
►
Sign in to add a comment |
||||||
Comment 1 by bugdroid1@chromium.org
, Mar 2 2016