WebFonts UMA WebFont.HadBlankText and WebFont.BlankTextShownTime are broken |
||||
Issue descriptionThese metrics report different data from descriptions. For instrance, HadBlankText should not be reported if the font immediately uses a fallback font, but it's reported always, and meaning looks different case by case.
,
Mar 4 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/802475025dd1465c1f6f99b114d9b9ac7a37e110 commit 802475025dd1465c1f6f99b114d9b9ac7a37e110 Author: ksakamoto <ksakamoto@chromium.org> Date: Fri Mar 04 08:18:23 2016 BlankText UMAs should be reported only for webfonts in block period This fixes a bug where WebFont.HadBlankText and WebFont.BlankTextShownTime are reported incorrectly when the webfont falls back immediately, because of font-display:swap or the webfont intervention. BUG= 591304 Review URL: https://codereview.chromium.org/1764913003 Cr-Commit-Position: refs/heads/master@{#379246} [modify] https://crrev.com/802475025dd1465c1f6f99b114d9b9ac7a37e110/third_party/WebKit/Source/core/css/RemoteFontFaceSource.cpp [modify] https://crrev.com/802475025dd1465c1f6f99b114d9b9ac7a37e110/third_party/WebKit/Source/core/css/RemoteFontFaceSource.h
,
Mar 7 2016
Confirmed the fix in 51.0.2669.0 canary, using chrome://histograms. Requesting merge to M50 branch, as this bug affects UMA metrics we are tracking for the WebFont intervention experiment (crbug.com/576563).
,
Mar 7 2016
Your change meets the bar and is auto-approved for M50 (branch: 2661)
,
Mar 7 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/ad3c88f77d543f648f622980178fa453503d6c94 commit ad3c88f77d543f648f622980178fa453503d6c94 Author: Kunihiko Sakamoto <ksakamoto@chromium.org> Date: Mon Mar 07 03:46:42 2016 BlankText UMAs should be reported only for webfonts in block period This fixes a bug where WebFont.HadBlankText and WebFont.BlankTextShownTime are reported incorrectly when the webfont falls back immediately, because of font-display:swap or the webfont intervention. BUG= 591304 Review URL: https://codereview.chromium.org/1764913003 Cr-Commit-Position: refs/heads/master@{#379246} (cherry picked from commit 802475025dd1465c1f6f99b114d9b9ac7a37e110) Review URL: https://codereview.chromium.org/1766993002 . Cr-Commit-Position: refs/branch-heads/2661@{#98} Cr-Branched-From: ef6f6ae5e4c96622286b563658d5cd62a6cf1197-refs/heads/master@{#378081} [modify] https://crrev.com/ad3c88f77d543f648f622980178fa453503d6c94/third_party/WebKit/Source/core/css/RemoteFontFaceSource.cpp [modify] https://crrev.com/ad3c88f77d543f648f622980178fa453503d6c94/third_party/WebKit/Source/core/css/RemoteFontFaceSource.h |
||||
►
Sign in to add a comment |
||||
Comment 1 by ksakamoto@chromium.org
, Mar 3 2016Status: Assigned (was: Available)