New issue
Advanced search Search tips

Issue 591280 link

Starred by 1 user
Status: Fixed
Owner:
yfried...@chromium.org
Closed: Mar 2016
Cc:
klo...@chromium.org
changwan@chromium.org
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 2
Type: Bug



Sign in to add a comment

Chrome's specialized handler check is too restrictive

Project Member Reported by yfried...@chromium.org, Mar 2 2016 
The very first commit of porting Android browser's "specialized handler check" copied a bug in verifying the intent handler as having either an authority or path and accidentally required both. (Internal repo commit hash: 32c8b342849557b142bac303717d3111e19348c8 and b/5768794)

It was later fixed in android browser https://android.googlesource.com/platform/packages/apps/Browser/+/0ffa9713dc66c4b0db3027a1edab52c99a3af129%5E%21/src/com/android/browser/UrlHandler.java but that patch never made it to our tree (b/5768794)

I'll merge this to chrome
Project Member

Comment 1 by bugdroid1@chromium.org, Mar 14 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/2bf85a70160c1408738b63c850647dd6e594290a

commit 2bf85a70160c1408738b63c850647dd6e594290a
Author: yfriedman <yfriedman@chromium.org>
Date: Mon Mar 14 14:31:44 2016

Fix bug in specialized handler logic.

It was too demanding requiring both authority and path rather than just
one. More info in attached bug.
Also begins adding unit tests for this code.

BUG= 591280 

Review URL: https://codereview.chromium.org/1786813003

Cr-Commit-Position: refs/heads/master@{#380970}

[modify] https://crrev.com/2bf85a70160c1408738b63c850647dd6e594290a/chrome/android/java/src/org/chromium/chrome/browser/externalnav/ExternalNavigationDelegateImpl.java
[add] https://crrev.com/2bf85a70160c1408738b63c850647dd6e594290a/chrome/android/javatests/src/org/chromium/chrome/browser/externalnav/ExternalNavigationDelegateImplTest.java

Comment 2 by yfried...@chromium.org, Mar 14 2016

Status: Fixed (was: Started)
►

Sign in to add a comment