USING_SYSTEM_ICU in config.gyp does not take effects in blink_platform.gyp |
|||
Issue descriptionOriginated in issue 584920 , when use_system_icu=1 is set in GYP_DEFINES, USING_SYSTEM_ICU defined in config.gyp (added in CL[1]) works for wtf.gyp but not for blink_platform.gyp. Note, use_system_icu=1 does not seem to work when it's used alone, that makes debugging a bit harder. Distributors using "unbundle"[2] and with several other variables hit this issue. See issue 584920 for other variables to repro. Currently a workaround[3] is in progress, but it is not a real fix. [1] https://codereview.chromium.org/1167523003 [2] https://code.google.com/p/chromium/codesearch#chromium/src/build/linux/unbundle/README&q=unbundle&sq=package:chromium&type=cs&l=43 [3] https://codereview.chromium.org/1754603002
,
Apr 18 2016
Blink>ToolsTest renamed to Blink>Infra
,
Dec 16 2016
kojii@: Is this still relevant now that we're using GN rather than GYP?
,
Dec 20 2016
I don't think so, thank you for checking. Closing. |
|||
►
Sign in to add a comment |
|||
Comment 1 by tkent@chromium.org
, Apr 11 2016