CSS counter-reset not working on JS-inserted node
Reported by
ryan.gos...@gmail.com,
Mar 2 2016
|
||||||||||
Issue descriptionChrome Version : 48.0.2564.116 (Official Build) (64-bit) URLs (if applicable) : https://jsfiddle.net/oa2cua45/ Other browsers tested: Add OK or FAIL, along with the version, after other browsers where you have tested this issue: Safari: FAIL (Version 9.0.3 (11601.4.4)) Firefox: OK (38.0.1) Edge: OK (25.10586.0.0) Opera: FAIL (35.0.2066.82) What steps will reproduce the problem? See the js fiddle ( https://jsfiddle.net/oa2cua45/ ) What is the expected result? The last line should be "1. stuff three", since the inserted element "blah blah blah" should reset the counter being used. What happens instead? The last line is "3. stuff three" despite the counter reset.
,
Mar 11 2016
As per https://bugs.chromium.org/p/chromium/issues/detail?id=371814#c_id25016412 it looks like andersr@ doesn't actively contribute any more -- is it possible to route this to someone else?
,
Mar 11 2016
Setting as untriaged so this can go through the normal triage process. Also cc-ing ramya.v who has looked at some counter stuff in the past.
,
Mar 14 2016
,
Apr 15 2016
This is probably related to issue 599359 , but not sure if it is the same so leaving both bugs open.
,
Apr 22 2016
,
May 18 2016
,
May 18 2016
Doesn't seem like a regression as per comment 1
,
May 18 2016
(in particular, the patch linked in comment 1 was fixing some behavior with counter-reset:none, so I expect that before that patch we were more broken?)
,
Jun 3 2016
Is there some timeline when we can expect this to be fixed? This bug has been causing production issues in Quora's rich text editor, and while we've got a workaround right now of rerendering editor contents whenever counters would be affected, it would be nice if we didn't have to do this.
,
Feb 13 2017
,
Oct 30 2017
,
Oct 31 2017
Should be approachable, but could potentially be a bug in Blink>Layout.
,
Dec 6 2017
,
Dec 12 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/03c0c40d9fd01a01d3ea7992fa3779a876a3740e commit 03c0c40d9fd01a01d3ea7992fa3779a876a3740e Author: Darren Shen <shend@chromium.org> Date: Tue Dec 12 04:21:51 2017 [css-counters] Update counters correctly under counter-reset changes. Currently we are not updating counter values correctly when we change or add counter-resets. For example, if we have something like: <div style="counter-reset: c"> <p style="counter-increment: c">First</p> <p style="counter-increment: c">Second</p> </div> we would construct the following counter tree (approximately): reset increment // first increment // second When we insert a new reset node after the first item, we would get something like: reset increment // first increment // second reset The correct behaviour would be to move every (non-reset) counter node after the first node to be a child of the new node: reset increment // first reset increment // second Bug: 463513 , 599359 , 591267 Change-Id: I28cbf3c13c86336ad3f6f44bf865c59d9f82d98a Reviewed-on: https://chromium-review.googlesource.com/809984 Reviewed-by: Koji Ishii <kojii@chromium.org> Commit-Queue: Darren Shen <shend@chromium.org> Cr-Commit-Position: refs/heads/master@{#523333} [add] https://crrev.com/03c0c40d9fd01a01d3ea7992fa3779a876a3740e/third_party/WebKit/LayoutTests/fast/css/counters/update-reset-counter-parent-sibling.html [add] https://crrev.com/03c0c40d9fd01a01d3ea7992fa3779a876a3740e/third_party/WebKit/LayoutTests/fast/css/counters/update-reset-counter-sibling.html [modify] https://crrev.com/03c0c40d9fd01a01d3ea7992fa3779a876a3740e/third_party/WebKit/Source/core/layout/CounterNode.cpp [modify] https://crrev.com/03c0c40d9fd01a01d3ea7992fa3779a876a3740e/third_party/WebKit/Source/core/layout/CounterNode.h [modify] https://crrev.com/03c0c40d9fd01a01d3ea7992fa3779a876a3740e/third_party/WebKit/Source/core/layout/LayoutCounter.cpp
,
Dec 12 2017
|
||||||||||
►
Sign in to add a comment |
||||||||||
Comment 1 by kavvaru@chromium.org
, Mar 3 2016Components: Blink>CSS
Labels: -Type-Bug M-51 hasbisect Type-Bug-Regression OS-All
Owner: ande...@opera.com
Status: Assigned (was: Unconfirmed)