New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 591260 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Long OOO (go/where-is-mgiuca)
Closed: Mar 2016
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug



Sign in to add a comment

Change "fullscreen" to "full screen"

Project Member Reported by mgiuca@chromium.org, Mar 2 2016

Issue description

The fullscreen bubble reads "Press [Esc] to exit fullscreen". It should read "to exit full screen", for platform consistency (all other major browsers and apps on Windows and Mac use two words "full screen").

 https://crbug.com/588110#c14 
 
Project Member

Comment 1 by bugdroid1@chromium.org, Mar 15 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/5aa4bd9331e2bc1c20cfbf9bfee703c16107bf0d

commit 5aa4bd9331e2bc1c20cfbf9bfee703c16107bf0d
Author: mgiuca <mgiuca@chromium.org>
Date: Tue Mar 15 00:42:26 2016

Update "fullscreen" to "full screen" in all strings.

Notably, the fullscreen bubble now says "Press Esc to exit full screen".

BUG= 591260 

Review URL: https://codereview.chromium.org/1755953002

Cr-Commit-Position: refs/heads/master@{#381138}

[modify] https://crrev.com/5aa4bd9331e2bc1c20cfbf9bfee703c16107bf0d/chrome/android/java/strings/android_chrome_strings.grd
[modify] https://crrev.com/5aa4bd9331e2bc1c20cfbf9bfee703c16107bf0d/chrome/app/generated_resources.grd

Comment 2 by mgiuca@chromium.org, Mar 15 2016

Status: Fixed (was: Assigned)

Sign in to add a comment