Chrome fails on conformance2/transform_feedback/transform_feedback.html |
||
Issue descriptionWhat steps will reproduce the problem? 1. open chrome with command line: --enable-unsafe-es3-apis 2. open https://www.khronos.org/registry/webgl/sdk/tests/conformance2/transform_feedback/transform_feedback.html?webglVersion=2 What is the expected output? What do you see instead? The test should pass in WebGL 2.0 context. But some tests fail. That's because transform feedback buffer isn't correctly cached in command buffer. There are some disscussions at: https://github.com/KhronosGroup/WebGL/pull/1513 and https://codereview.chromium.org/1752703003/.
,
Mar 11 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/4c10b3e03cdf3028c9e66aaa4d4e9236c856cf68 commit 4c10b3e03cdf3028c9e66aaa4d4e9236c856cf68 Author: qiankun.miao <qiankun.miao@intel.com> Date: Fri Mar 11 12:33:31 2016 Fix transform feedback bugs This CL fixes two bugs: 1. Deleting an active transform feedback object will generate INVALID_OPERATION error (page 86, ES spec 3.0.4). 2. bindBufferBase bind the buffer object to both the general binding point and the binding point in the array givien by index (page 35, ES spec 3.0.4). BUG= 295792 , 591258 TEST=deqp/functional/gles3/lifetime.html CQ_INCLUDE_TRYBOTS=tryserver.chromium.win:win_optional_gpu_tests_rel Review URL: https://codereview.chromium.org/1752703003 Cr-Commit-Position: refs/heads/master@{#380610} [modify] https://crrev.com/4c10b3e03cdf3028c9e66aaa4d4e9236c856cf68/gpu/command_buffer/build_gles2_cmd_buffer.py [modify] https://crrev.com/4c10b3e03cdf3028c9e66aaa4d4e9236c856cf68/gpu/command_buffer/client/gles2_implementation.cc [modify] https://crrev.com/4c10b3e03cdf3028c9e66aaa4d4e9236c856cf68/gpu/command_buffer/service/gles2_cmd_decoder.cc [modify] https://crrev.com/4c10b3e03cdf3028c9e66aaa4d4e9236c856cf68/gpu/command_buffer/service/gles2_cmd_decoder_unittest_1_autogen.h [modify] https://crrev.com/4c10b3e03cdf3028c9e66aaa4d4e9236c856cf68/gpu/command_buffer/service/gles2_cmd_decoder_unittest_buffers.cc [modify] https://crrev.com/4c10b3e03cdf3028c9e66aaa4d4e9236c856cf68/third_party/WebKit/Source/modules/webgl/WebGL2RenderingContextBase.cpp
,
Apr 12 2016
This is fixed by above CL. |
||
►
Sign in to add a comment |
||
Comment 1 by kbr@chromium.org
, Mar 2 2016