Unable to have 'private' public suffices with wildcards or exception |
|||
Issue descriptionmake_dafsa.py is used to process the PSL and generate the compiled-in DAFSA. While the Chromium implementation of (effective_tld_names.gperf, registry_controlled_domain.*) treats the status as a bitmask, make_dafsa.py treats it as discrete values. As such, make_dafsa.py rejects certificates that are wildcard-and-private (2 + 4 == 6) or that are exceptions-and-private (1 + 4 = 5). This is blocking updating to the latest versions of the PSL, as Github has several wildcarded private domains included in the latest version.
,
Apr 4 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/fbc95014262c9b56a79859a3ef79309d19246173 commit fbc95014262c9b56a79859a3ef79309d19246173 Author: Ryan Sleevi <rsleevi@chromium.org> Date: Mon Apr 04 23:24:41 2016 Support all possible bitflags when computing the PSL DAFSA make_dafsa.py restricted the set of flags a given eTLD could have to being the discrete values (0, 1, 2, 4), but the underlying implementation is as a bitmask. Support the entire range of valid values within make_dafsa, so that non-ICANN eTLDs can have wildcards or exceptions BUG= 591253 Review URL: https://codereview.chromium.org/1756733003 Cr-Commit-Position: refs/heads/master@{#379167} (cherry picked from commit 55859a4ac6f8d43c63752ddcba20c6df76710e1f) Review URL: https://codereview.chromium.org/1860753005 . Cr-Commit-Position: refs/branch-heads/2661@{#487} Cr-Branched-From: ef6f6ae5e4c96622286b563658d5cd62a6cf1197-refs/heads/master@{#378081} [modify] https://crrev.com/fbc95014262c9b56a79859a3ef79309d19246173/net/tools/dafsa/make_dafsa.py [modify] https://crrev.com/fbc95014262c9b56a79859a3ef79309d19246173/net/tools/dafsa/make_dafsa_unittest.py
,
Jul 6 2016
|
|||
►
Sign in to add a comment |
|||
Comment 1 by bugdroid1@chromium.org
, Mar 4 2016