Pipeline errors are spuriously reported during destruction and suspension. |
||||
Issue descriptionThese errors either don't matter or are recoverable when the player is resumed, we should not count them toward our error rates in UMA.
,
Mar 3 2016
Will wait for this to hit M51 and then merge if it improves our rates.
,
Mar 3 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/2ff781da56aa95ad5bb8be9075abf97cf26c82aa commit 2ff781da56aa95ad5bb8be9075abf97cf26c82aa Author: dalecurtis <dalecurtis@chromium.org> Date: Thu Mar 03 01:52:13 2016 Supress pipeline errors during destruction and suspend. These errors either don't matter or will be recovered naturally the next time the player is interacted with. We should not count these towards our failure rates. BUG= 591244 TEST=modified unittests. Review URL: https://codereview.chromium.org/1753043002 Cr-Commit-Position: refs/heads/master@{#378916} [modify] https://crrev.com/2ff781da56aa95ad5bb8be9075abf97cf26c82aa/media/base/demuxer.h [modify] https://crrev.com/2ff781da56aa95ad5bb8be9075abf97cf26c82aa/media/base/pipeline_impl.cc [modify] https://crrev.com/2ff781da56aa95ad5bb8be9075abf97cf26c82aa/media/base/pipeline_impl_unittest.cc [modify] https://crrev.com/2ff781da56aa95ad5bb8be9075abf97cf26c82aa/media/blink/webmediaplayer_impl.cc [modify] https://crrev.com/2ff781da56aa95ad5bb8be9075abf97cf26c82aa/media/blink/webmediaplayer_impl.h
,
Mar 7 2016
,
Mar 21 2016
Hmmm, this apparently never got merged even though it's tagged as having been merged for some reason! Will have to manually review the past few merges to figure out what happened here.
,
Mar 21 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/5792075b8b5267e8f9a29a90b2c6b240891a7761 commit 5792075b8b5267e8f9a29a90b2c6b240891a7761 Author: Dale Curtis <dalecurtis@chromium.org> Date: Mon Mar 21 17:46:56 2016 Merge M50: "Supress pipeline errors during destruction and suspend." These errors either don't matter or will be recovered naturally the next time the player is interacted with. We should not count these towards our failure rates. BUG= 591244 TEST=modified unittests. Review URL: https://codereview.chromium.org/1753043002 Cr-Commit-Position: refs/heads/master@{#378916} (cherry picked from commit 2ff781da56aa95ad5bb8be9075abf97cf26c82aa) Review URL: https://codereview.chromium.org/1819023002 . Cr-Commit-Position: refs/branch-heads/2661@{#314} Cr-Branched-From: ef6f6ae5e4c96622286b563658d5cd62a6cf1197-refs/heads/master@{#378081} [modify] https://crrev.com/5792075b8b5267e8f9a29a90b2c6b240891a7761/media/base/demuxer.h [modify] https://crrev.com/5792075b8b5267e8f9a29a90b2c6b240891a7761/media/base/pipeline_impl.cc [modify] https://crrev.com/5792075b8b5267e8f9a29a90b2c6b240891a7761/media/base/pipeline_impl_unittest.cc [modify] https://crrev.com/5792075b8b5267e8f9a29a90b2c6b240891a7761/media/blink/webmediaplayer_impl.cc [modify] https://crrev.com/5792075b8b5267e8f9a29a90b2c6b240891a7761/media/blink/webmediaplayer_impl.h |
||||
►
Sign in to add a comment |
||||
Comment 1 by bugdroid1@chromium.org
, Mar 3 2016