New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 591241 link

Starred by 2 users

Issue metadata

Status: Verified
Owner:
Closed: Mar 2016
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 2
Type: Bug



Sign in to add a comment

ash::ScreenUtil::GetSecondaryDisplay

Project Member Reported by rookrishna@chromium.org, Mar 2 2016

Issue description

Google Chrome	50.0.2661.1 (Official Build) dev (64-bit)
Revision	0
Platform	7978.2.0 (Official Build) dev-channel samus

Please specify Cr-* of the system to which this bug/feature applies (add
the label below).

Crash ID - 8288c6f000000000


Thread 0 CRASHED [SIGABRT @ 0x000003e800001c9e ] MAGIC SIGNATURE THREAD
0x00007f97e215ab82	(libc-2.19.so -raise.c:56 )	raise
0x00007f97e215c89f	(libc-2.19.so -abort.c:89 )	abort
0x00007f97e4fc3b84	(chrome -debugger_posix.cc:248 )	base::debug::BreakDebugger
0x00007f97e6efa2e4	(chrome -screen_util.cc:103 )	ash::ScreenUtil::GetSecondaryDisplay
0x00007f97e6eccf30	(chrome -accelerator_controller.cc:631 )	ash::::HandleSwapPrimaryDisplay
0x00007f97e6ecf63b	(chrome -accelerator_controller.cc:1341 )	ash::AcceleratorController::PerformAction
0x00007f97e6ecf8f1	(chrome -accelerator_controller.cc:882 )	ash::AcceleratorController::AcceleratorPressed
0x00007f97e84d90d2	(chrome -accelerator_manager.cc:88 )	ui::AcceleratorManager::Process
0x00007f97e6f52a7c	(chrome -accelerator_delegate.cc:32 )	ash::AcceleratorDelegate::ProcessAccelerator
0x00007f97e76820e5	(chrome -accelerator_filter.cc:73 )	wm::AcceleratorFilter::OnKeyEvent
0x00007f97e84e8216	(chrome -event_dispatcher.cc:191 )	ui::EventDispatcher::DispatchEvent
 
Owner: osh...@chromium.org
Status: Assigned (was: Untriaged)
Status: Started (was: Assigned)
Project Member

Comment 3 by bugdroid1@chromium.org, Mar 3 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/5e01dfa96782c9d75ea35ad31f24909759ce1455

commit 5e01dfa96782c9d75ea35ad31f24909759ce1455
Author: oshima <oshima@chromium.org>
Date: Thu Mar 03 20:51:37 2016

Enable swap primary accelerator only when possible

BUG= 591241 
TEST=manual

Review URL: https://codereview.chromium.org/1759213002

Cr-Commit-Position: refs/heads/master@{#379082}

[modify] https://crrev.com/5e01dfa96782c9d75ea35ad31f24909759ce1455/ash/accelerators/accelerator_controller.cc

Labels: Merge-Request-50
Cc: sontis@chromium.org ka...@chromium.org shrawan@chromium.org
 Issue 591790  has been merged into this issue.

Comment 6 by tin...@google.com, Mar 4 2016

Labels: -Merge-Request-50 Merge-Approved-50 Hotlist-Merge-Approved
Your change meets the bar and is auto-approved for M50 (branch: 2661)
Project Member

Comment 7 by bugdroid1@chromium.org, Mar 4 2016

Labels: -merge-approved-50 merge-merged-2661
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/1ee56006712688341ea72bb69d1562b6bfc709c6

commit 1ee56006712688341ea72bb69d1562b6bfc709c6
Author: Mitsuru Oshima <oshima@chromium.org>
Date: Fri Mar 04 20:57:34 2016

Enable swap primary accelerator only when possible

BUG= 591241 
TEST=manual
TBR=oshima@chromium.org

Review URL: https://codereview.chromium.org/1759213002

Cr-Commit-Position: refs/heads/master@{#379082}
(cherry picked from commit 5e01dfa96782c9d75ea35ad31f24909759ce1455)

Review URL: https://codereview.chromium.org/1768663002 .

Cr-Commit-Position: refs/branch-heads/2661@{#85}
Cr-Branched-From: ef6f6ae5e4c96622286b563658d5cd62a6cf1197-refs/heads/master@{#378081}

[modify] https://crrev.com/1ee56006712688341ea72bb69d1562b6bfc709c6/ash/accelerators/accelerator_controller.cc

Status: Fixed (was: Started)
Status: Verified (was: Fixed)
verified in ChromeOS 7978.16.0 / 50.0.2661.31

Sign in to add a comment