chrome://apps: last dragged page no longer sticky |
||||
Issue descriptionWhat steps will reproduce the problem? 0. have historical product knowledge and navigate to chrome://apps 1. drag and drop on app onto a new "Apps" page 2. reload or revisit chrome://apps What is the expected result? I expect the last page I dragged/moved to. What happens instead of that? I get the first page (i.e. the page isn't remembered). Please provide any additional information below. Attach a screenshot if possible. This used to work.
,
Mar 2 2016
,
Mar 2 2016
treib@: rsesek@ mentioned that we'd be removing the promo service, so I started going down the rabbit hole for him, removing that specific UI and supporting C++. I changed the code so much that your CL would've conflicted a lot, so I removed part of what you wanted to remove myself. there is probably still plenty of dead code :( and you're more than welcome to remove the other things you believe to be dead, it's just that the NTP is poorly tested and surgical precision is advised (I grepped for every identifier I came across).
,
Mar 3 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/1f8acc51c0c5d9fea66917884b927eff8f3e570e commit 1f8acc51c0c5d9fea66917884b927eff8f3e570e Author: dbeam <dbeam@chromium.org> Date: Thu Mar 03 22:28:10 2016 NTP4/apps page: fix page stickiness R=estade@chromium.org BUG= 591225 Review URL: https://codereview.chromium.org/1757673002 Cr-Commit-Position: refs/heads/master@{#379115} [modify] https://crrev.com/1f8acc51c0c5d9fea66917884b927eff8f3e570e/chrome/browser/resources/ntp4/page_list_view.js [modify] https://crrev.com/1f8acc51c0c5d9fea66917884b927eff8f3e570e/chrome/browser/ui/webui/ntp/app_launcher_handler.cc [modify] https://crrev.com/1f8acc51c0c5d9fea66917884b927eff8f3e570e/chrome/browser/ui/webui/ntp/app_launcher_handler.h [delete] https://crrev.com/ebaca1a5f5909b5cacbb3ebebbacb1968486cd16/chrome/browser/ui/webui/ntp/new_tab_page_handler.cc [delete] https://crrev.com/ebaca1a5f5909b5cacbb3ebebbacb1968486cd16/chrome/browser/ui/webui/ntp/new_tab_page_handler.h [modify] https://crrev.com/1f8acc51c0c5d9fea66917884b927eff8f3e570e/chrome/browser/ui/webui/ntp/new_tab_ui.cc [modify] https://crrev.com/1f8acc51c0c5d9fea66917884b927eff8f3e570e/chrome/browser/ui/webui/ntp/ntp_resource_cache.cc [modify] https://crrev.com/1f8acc51c0c5d9fea66917884b927eff8f3e570e/chrome/chrome_browser_ui.gypi
,
Mar 22 2016
Issue 596428 has been merged into this issue.
,
Mar 22 2016
,
May 6 2016
|
||||
►
Sign in to add a comment |
||||
Comment 1 by treib@chromium.org
, Mar 2 2016