New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 591209 link

Starred by 1 user
Status: Fixed
Owner:
█ roc...@chromium.org
please use my google.com address
Closed: Mar 2016
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug



Sign in to add a comment

Refactor mojo::shell::ChildProcessHost to be more friendly to Chrome process launch

Project Member Reported by roc...@chromium.org, Mar 1 2016 
Support for hosting child processes not launched directly by the ChildProcessHost is fragile and not correct. We should fix this.
Project Member

Comment 1 by bugdroid1@chromium.org, Mar 2 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/1a4ffc89ec7416f2ccc69d7e5a74e5ab2f30ab66

commit 1a4ffc89ec7416f2ccc69d7e5a74e5ab2f30ab66
Author: rockot <rockot@chromium.org>
Date: Wed Mar 02 02:03:58 2016

In Chrome, we always let content launch child processes, and as such have
no need for ChildProcessHost's synchronization logic. Furthermore, we use
ChildProcessHost on the main thread where such logic is illegal.

This updates ChildProcessHost to be more Chrome-friendly.

BUG= 591209 ,591190
TBR=ben@chromium.org

Review URL: https://codereview.chromium.org/1754003002

Cr-Commit-Position: refs/heads/master@{#378649}

[modify] https://crrev.com/1a4ffc89ec7416f2ccc69d7e5a74e5ab2f30ab66/mojo/shell/runner/host/child_process_host.cc
[modify] https://crrev.com/1a4ffc89ec7416f2ccc69d7e5a74e5ab2f30ab66/mojo/shell/runner/host/child_process_host.h

Comment 2 by roc...@chromium.org, Mar 27 2016

Status: Fixed (was: Assigned)
►

Sign in to add a comment