New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 591193 link

Starred by 1 user

Issue metadata

Status: Assigned
Owner:
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 2
Type: Bug



Sign in to add a comment

platform_keys unittests should not depend on behaviours of //net/data/ssl/certificates

Project Member Reported by rsleevi@chromium.org, Mar 1 2016

Issue description

The platform_keys unittests have hardcoded values extracted from certificates and keys generated in //net/data/ssl/certificates

The entire reason //net/data/ssl/certificates exists is to prevent hardcoding, and allow easy script-based re-generation based on changing needs (such as changes in algorithms or key sizes, or the addition of new test files)

While trying to re-generate the client certificates, it was discovered that //chrome/test/data/extensions/api_test/platform_keys hardcodes a number of values from the certificates in //net. This should not be done.

The platform_keys unit test should be responsible for generating (or re-generating) all of its test data hermetically, on demand. This potentially means generating client certificates and signatures, if needed - presumably, as part of create_test_certs.sh

There should be no dependency on //net code or, if there is, it should automatically re-generate on change (such as build rules). Going the route of create_test_certs.sh is the most efficient route, since it only needs to be run once and checked in.

[I missed this when reviewing the original CL, https://codereview.chromium.org/884073002/ ]

 

Sign in to add a comment