hung renderer UX inconsistent |
|||
Issue descriptionThis is fairly obscure (only discovered by reading code and verifying manually): - when you press kill, it kills the tab - when you press "wait", it closes the dialog and restarts the hung renderer monitoring - when you press escape, it closes the dialog BUT neither kills nor resumes waiting. This is somewhat papered over by the fact that switching to a different tab and back, or typing into the hung tab, will also restart the hung renderer monitoring.
,
Mar 1 2016
p.s. for reference, manually editing kHungRendererDelayMs helps substiantially in debugging this
,
Mar 2 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/1203e605ab26d27ee100afaec794d3c77beaa2a4 commit 1203e605ab26d27ee100afaec794d3c77beaa2a4 Author: estade <estade@chromium.org> Date: Wed Mar 02 02:21:15 2016 Remove DialogDelegate::Accept() variant The one and only place it was used (HungRendererDialogView) was unnecessary. Overriding Close() to no-op would accomplish the same behavior. However I also discovered a bug (linked below) which I fixed. So this patch creates a behavioral change: pressing escape or otherwise closing the window does the same thing as pressing "Wait", which I believe is desirable. BUG= 591186 , 585312 Review URL: https://codereview.chromium.org/1752623004 Cr-Commit-Position: refs/heads/master@{#378659} [modify] https://crrev.com/1203e605ab26d27ee100afaec794d3c77beaa2a4/chrome/browser/ui/views/hung_renderer_view.cc [modify] https://crrev.com/1203e605ab26d27ee100afaec794d3c77beaa2a4/chrome/browser/ui/views/hung_renderer_view.h [modify] https://crrev.com/1203e605ab26d27ee100afaec794d3c77beaa2a4/ui/views/window/dialog_client_view.cc [modify] https://crrev.com/1203e605ab26d27ee100afaec794d3c77beaa2a4/ui/views/window/dialog_delegate.cc [modify] https://crrev.com/1203e605ab26d27ee100afaec794d3c77beaa2a4/ui/views/window/dialog_delegate.h
,
Mar 3 2016
,
May 3 2016
|
|||
►
Sign in to add a comment |
|||
Comment 1 by est...@chromium.org
, Mar 1 2016