New issue
Advanced search Search tips

Issue 591183 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Apr 2016
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux
Pri: 2
Type: Bug



Sign in to add a comment

dry run only works sometimes for me

Project Member Reported by cblume@chromium.org, Mar 1 2016

Issue description

A dry run will sometimes work and sometimes not for me.

An example can be found here:
https://codereview.chromium.org/1750303002

If you look at the timings, you'll see that the first few dry runs worked. Then later they stopped so I manually added all the bots.
 
Cc: rmis...@chromium.org
Labels: Infra-Client-Skia
Status: Untriaged (was: Unconfirmed)
+rmistry@ for Skia - have you considered https://chrome-internal.googlesource.com/infra/infra_internal/+/master/commit_queue/cq_client/cq.proto#153 ?
also, i have no idea yet what's going on for cblume@ but it could be related.

setting untriaged so we look at this in CQ daily.

Comment 2 by aga...@chromium.org, Apr 26 2016

Components: Infra>CQ
Labels: -Infra-CommitQueue

Comment 3 by benhenry@google.com, Apr 27 2016

Components: Infra>Client>Skia
Labels: -Infra-Client-Skia
Project Member

Comment 4 by bugdroid1@chromium.org, Apr 27 2016

The following revision refers to this bug:
  https://skia.googlesource.com/skia.git/+/12135f50bd8d7d8abbb2befb99a9784043cb90e5

commit 12135f50bd8d7d8abbb2befb99a9784043cb90e5
Author: rmistry <rmistry@google.com>
Date: Wed Apr 27 16:43:20 2016

Add dry_run_access_list to Skia's cq.proto

This will give all users who have access to our trybots access to our dry run CQ as well.

BUG= 591183 
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1926783002

Review-Url: https://codereview.chromium.org/1926783002

[modify] https://crrev.com/12135f50bd8d7d8abbb2befb99a9784043cb90e5/infra/branch-config/cq.cfg

Project Member

Comment 5 by bugdroid1@chromium.org, Apr 27 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/d498f73318d81d050b97d09d11697857abd12863

commit d498f73318d81d050b97d09d11697857abd12863
Author: skia-deps-roller <skia-deps-roller@chromium.org>
Date: Wed Apr 27 20:28:46 2016

Roll src/third_party/skia/ 6f47dbaff..eabaf7982 (14 commits).

https://chromium.googlesource.com/skia.git/+log/6f47dbaff54a..eabaf798249e

$ git log 6f47dbaff..eabaf7982 --date=short --no-merges --format='%ad %ae %s'
2016-04-27 halcanary SkDocument::CreateXPS fix roll
2016-04-27 jvanverth Remove AttachmentInfo from VulkanViewer setup
2016-04-27 egdaniel Add work around for vulkan copies on the 5X
2016-04-27 senorblanco Image filters: de-nest SkImageFilter::Cache and Cache::Key.
2016-04-27 halcanary SkPDF/None: fix compilation
2016-04-27 robertphillips Bring sk_sp to GrDrawContext
2016-04-27 bungeman Add oblique as a slant.
2016-04-27 rmistry Add dry_run_access_list to Skia's cq.proto
2016-04-27 mtklein Revert of Enable flattening of SkRecordedDrawable (patchset #8 id:140001 of https://codereview.chromium.org/1913843002/ )
2016-04-27 msarett Enable flattening of SkRecordedDrawable
2016-04-27 djsollen Upgrade Android Gradle plugins GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1926743002
2016-04-27 reed remove 'deprecated' region from SkDraw
2016-04-27 halcanary SkDocument/PDF: new API
2016-04-27 halcanary tools/pdf-comparison.sh: stop relying on /usr/bin/timeout

BUG= 591183 

CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel
TBR=stephana@google.com

Review-Url: https://codereview.chromium.org/1923623003
Cr-Commit-Position: refs/heads/master@{#390168}

[modify] https://crrev.com/d498f73318d81d050b97d09d11697857abd12863/DEPS

Cc: -rmis...@chromium.org
Owner: rmis...@chromium.org
Status: Fixed (was: Untriaged)
Looks like this was fixed. Please reopen if not.
Components: Infra>Client
Components: -Infra>Client>Skia

Sign in to add a comment