New issue
Advanced search Search tips

Issue 591166 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Mar 2016
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: All
Pri: 2
Type: Bug



Sign in to add a comment

[Autofill] Heuristics don't detect CC number on united.com.

Project Member Reported by se...@chromium.org, Mar 1 2016

Issue description

The reason is that one of the cc-number fields has type="password".

 

Comment 2 by se...@chromium.org, Mar 4 2016

Status: Fixed (was: Started)
Project Member

Comment 3 by bugdroid1@chromium.org, Apr 4 2016

Labels: merge-merged-2661
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/71634987bfffd49d609d37ae4a9747c17b6e291e

commit 71634987bfffd49d609d37ae4a9747c17b6e291e
Author: Justin Donnelly <jdonnelly@chromium.org>
Date: Mon Apr 04 17:32:09 2016

[Autofill] Fix heuristics to detect cc-number on united.com.

The reason was that one of the cc-number fields has type="password", and we didn't support this type for cc-number fields.

BUG= 591166 , 598873 

Review URL: https://codereview.chromium.org/1754793003

Cr-Commit-Position: refs/heads/master@{#379287}
(cherry picked from commit d5a83da5b2571eeb25b61f4b4bd6424b0695fb33)

Review URL: https://codereview.chromium.org/1859633002 .

Cr-Commit-Position: refs/branch-heads/2661@{#476}
Cr-Branched-From: ef6f6ae5e4c96622286b563658d5cd62a6cf1197-refs/heads/master@{#378081}

[add] https://crrev.com/71634987bfffd49d609d37ae4a9747c17b6e291e/chrome/test/data/autofill/heuristics/input/138_cc_checkout_united.com.html
[add] https://crrev.com/71634987bfffd49d609d37ae4a9747c17b6e291e/chrome/test/data/autofill/heuristics/output/138_cc_checkout_united.com.out
[modify] https://crrev.com/71634987bfffd49d609d37ae4a9747c17b6e291e/components/autofill/core/browser/credit_card_field.cc

Sign in to add a comment