Refactor to use DidFinishNavigation |
|||||
Issue descriptionPer the discussion in https://codereview.chromium.org/1721103002/, we want to refactor to use DidFailNavigation instead of DidFailProvisionalLoad. When we tried this before, the progress bar got refreshed twice. Maybe it isn't a problem, but we should investigate. We need to modify SimulateNavigationError() to generate DidFailNavigation. There may be other test code infrastructure that needs to change as part of this to be able to test it.
,
Mar 7 2016
,
Mar 8 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/2ec1dfed7c0e8e9d29ce1c0366321426a8c1b489 commit 2ec1dfed7c0e8e9d29ce1c0366321426a8c1b489 Author: petewil <petewil@chromium.org> Date: Tue Mar 08 03:57:08 2016 One of the outstanding TODO items from our fix to redirect navigations to offline pages was to switch from the provisional load events to use the newer navigation events. This change switches to the new events, and adds a working test. BUG= 591150 Review URL: https://codereview.chromium.org/1754333002 Cr-Commit-Position: refs/heads/master@{#379725} [modify] https://crrev.com/2ec1dfed7c0e8e9d29ce1c0366321426a8c1b489/chrome/browser/android/offline_pages/offline_page_tab_helper.cc [modify] https://crrev.com/2ec1dfed7c0e8e9d29ce1c0366321426a8c1b489/chrome/browser/android/offline_pages/offline_page_tab_helper.h [modify] https://crrev.com/2ec1dfed7c0e8e9d29ce1c0366321426a8c1b489/chrome/browser/android/offline_pages/offline_page_tab_helper_unittest.cc
,
Mar 8 2016
,
Mar 23 2016
,
Mar 23 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/00ff65bb8d9ece36057585c3a31439adbfd79d1f commit 00ff65bb8d9ece36057585c3a31439adbfd79d1f Author: Pete Williamson <petewil@chromium.org> Date: Wed Mar 23 18:13:04 2016 One of the outstanding TODO items from our fix to redirect navigations to offline pages was to switch from the provisional load events to use the newer navigation events. This change switches to the new events, and adds a working test. BUG= 591150 Review URL: https://codereview.chromium.org/1754333002 Cr-Commit-Position: refs/heads/master@{#379725} (cherry picked from commit 2ec1dfed7c0e8e9d29ce1c0366321426a8c1b489) Review URL: https://codereview.chromium.org/1829853002 . Cr-Commit-Position: refs/branch-heads/2661@{#363} Cr-Branched-From: ef6f6ae5e4c96622286b563658d5cd62a6cf1197-refs/heads/master@{#378081} [modify] https://crrev.com/00ff65bb8d9ece36057585c3a31439adbfd79d1f/chrome/browser/android/offline_pages/offline_page_tab_helper.cc [modify] https://crrev.com/00ff65bb8d9ece36057585c3a31439adbfd79d1f/chrome/browser/android/offline_pages/offline_page_tab_helper.h [modify] https://crrev.com/00ff65bb8d9ece36057585c3a31439adbfd79d1f/chrome/browser/android/offline_pages/offline_page_tab_helper_unittest.cc |
|||||
►
Sign in to add a comment |
|||||
Comment 1 by fgor...@chromium.org
, Mar 2 2016