Images in simplified page are bigger than the original images
Reported by
dalmirda...@gmail.com,
Mar 1 2016
|
||||||||||
Issue descriptionUserAgent: Mozilla/5.0 (X11; Linux x86_64) AppleWebKit/537.36 (KHTML, like Gecko) Ubuntu Chromium/48.0.2564.82 Chrome/48.0.2564.82 Safari/537.36 Steps to reproduce the problem: 1. Go to http://www.nytimes.com/2016/02/28/magazine/what-google-learned-from-its-quest-to-build-the-perfect-team.html?_r=0 2. Simplify the page (inside print-preview). 3. See the simplified output. What is the expected behavior? Images should preserve their sizes. What went wrong? Small images lost their dimension attributes and got bigger than they were before the distillation. Did this work before? N/A Chrome version: 48.0.2564.82 Channel: stable OS Version: Ubuntu MATE 15.10 Flash Version:
,
Mar 2 2016
CL submitted here: https://codereview.chromium.org/1754213004
,
Mar 8 2016
,
Apr 11 2016
Another example: http://www.cbs.com/shows/big_bang_theory/photos/1004104/most-explosive-relationship-bombs-from-season-finale-of-the-big-bang-theory/83698/ The control icons and social sharing icons become enormous after distillation.
,
Apr 11 2016
This commit https://github.com/chromium/dom-distiller/commit/84cfcd26c60ab6b1547dd4e08f35d236f566e5d1 should fix this issue. Code review (already merged into master): https://codereview.chromium.org/1754213004
,
Apr 22 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/04fe15d5c151bd41ad3f757e03977218f78e1828 commit 04fe15d5c151bd41ad3f757e03977218f78e1828 Author: mdjones <mdjones@chromium.org> Date: Fri Apr 22 22:26:23 2016 Roll DOM Distiller JavaScript distribution package Diff since last roll: https://github.com/chromium/dom-distiller/compare/349b932fc2...c3edb386a9 Picked up changes: c3edb38 Add travis-ci support adbdbec Fix for Schema.org title extraction. f40e521 Lazy evaluation of MarkupParsers 84cfcd2 Retain image sizes 3b3253f Make long strings easier to compare in assertion failure fc19f02 Clean attributes of mRoot between tests properly ccefff9 Handle drop cap letters 9101ca4 Fix spelling in comments cfb7588 Update README.md 4d0809f Reformat README.md to Google style 72998ef Add scripts for distillability modeling 7310b0f Process the root element in various DomUtil functions BUG= 483172 , 552408 , 576553 ,589294, 591143 , 593128 , 604177 ,605484 Review URL: https://codereview.chromium.org/1908173005 Cr-Commit-Position: refs/heads/master@{#389270} [modify] https://crrev.com/04fe15d5c151bd41ad3f757e03977218f78e1828/DEPS [modify] https://crrev.com/04fe15d5c151bd41ad3f757e03977218f78e1828/third_party/dom_distiller_js/README.chromium
,
Apr 27 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/8b8b020e81c365d23e59da605d022ec539039f26 commit 8b8b020e81c365d23e59da605d022ec539039f26 Author: Matthew Jones <mdjones@chromium.org> Date: Wed Apr 27 21:53:53 2016 Roll DOM Distiller JavaScript distribution package Diff since last roll: https://github.com/chromium/dom-distiller/compare/349b932fc2...c3edb386a9 Picked up changes: c3edb38 Add travis-ci support adbdbec Fix for Schema.org title extraction. f40e521 Lazy evaluation of MarkupParsers 84cfcd2 Retain image sizes 3b3253f Make long strings easier to compare in assertion failure fc19f02 Clean attributes of mRoot between tests properly ccefff9 Handle drop cap letters 9101ca4 Fix spelling in comments cfb7588 Update README.md 4d0809f Reformat README.md to Google style 72998ef Add scripts for distillability modeling 7310b0f Process the root element in various DomUtil functions BUG= 483172 , 552408 , 576553 ,589294, 591143 , 593128 , 604177 ,605484 Review URL: https://codereview.chromium.org/1908173005 Cr-Commit-Position: refs/heads/master@{#389270} (cherry picked from commit 04fe15d5c151bd41ad3f757e03977218f78e1828) Review URL: https://codereview.chromium.org/1923953004 . Cr-Commit-Position: refs/branch-heads/2704@{#276} Cr-Branched-From: 6e53600def8f60d8c632fadc70d7c1939ccea347-refs/heads/master@{#386251} [modify] https://crrev.com/8b8b020e81c365d23e59da605d022ec539039f26/DEPS [modify] https://crrev.com/8b8b020e81c365d23e59da605d022ec539039f26/third_party/dom_distiller_js/README.chromium
,
May 4 2016
Verified the issue on Ubuntu 14.04 using 51.0.2704.36 and its working fine now. Please find the attached screen cast for the same. mdjones@ : Could you please update the issue status to Fixed if there is no work to be done further in this.
,
Feb 15 2017
|
||||||||||
►
Sign in to add a comment |
||||||||||
Comment 1 by dalmirda...@gmail.com
, Mar 1 2016