New issue
Advanced search Search tips

Issue 591131 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Apr 2016
Cc:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug

Blocking:
issue 469801



Sign in to add a comment

Sync Confirmation is made unusable when increasing font size in chrome://settings

Project Member Reported by anthonyvd@chromium.org, Mar 1 2016

Issue description

The sync confirmation is implemented as web UI but it really is a part of Chrome UI, not content. As such, it shouldn't be affected by the content font size setting found in chrome://settings
 
Blocking: -469801
Project Member

Comment 2 by bugdroid1@chromium.org, Apr 5 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/0ac524ae54c5fc198593f34aa242ac504508f023

commit 0ac524ae54c5fc198593f34aa242ac504508f023
Author: anthonyvd <anthonyvd@chromium.org>
Date: Tue Apr 05 18:17:52 2016

Fix sizing issues in the tab modal signin flow.

This change increases the height of the sign in portion of the flow to
be tall enough to fit the content without a scrollbar. Longer content
doesn't break the flow but makes the scrollbar appear.

It also fixes the size of the details text in the sync confirmation
portion to a pixel value to prevent it from being affected by content
font size settings.

BUG=593499, 591131 ,589656

Review URL: https://codereview.chromium.org/1814513002

Cr-Commit-Position: refs/heads/master@{#385225}

[modify] https://crrev.com/0ac524ae54c5fc198593f34aa242ac504508f023/chrome/browser/resources/sync_confirmation/sync_confirmation.css
[modify] https://crrev.com/0ac524ae54c5fc198593f34aa242ac504508f023/chrome/browser/resources/sync_confirmation/sync_confirmation.js
[modify] https://crrev.com/0ac524ae54c5fc198593f34aa242ac504508f023/chrome/browser/ui/browser.h
[modify] https://crrev.com/0ac524ae54c5fc198593f34aa242ac504508f023/chrome/browser/ui/cocoa/profiles/signin_view_controller_delegate_mac.h
[modify] https://crrev.com/0ac524ae54c5fc198593f34aa242ac504508f023/chrome/browser/ui/cocoa/profiles/signin_view_controller_delegate_mac.mm
[modify] https://crrev.com/0ac524ae54c5fc198593f34aa242ac504508f023/chrome/browser/ui/signin_view_controller.h
[modify] https://crrev.com/0ac524ae54c5fc198593f34aa242ac504508f023/chrome/browser/ui/signin_view_controller_delegate.cc
[modify] https://crrev.com/0ac524ae54c5fc198593f34aa242ac504508f023/chrome/browser/ui/signin_view_controller_delegate.h
[modify] https://crrev.com/0ac524ae54c5fc198593f34aa242ac504508f023/chrome/browser/ui/views/profiles/signin_view_controller_delegate_views.cc
[modify] https://crrev.com/0ac524ae54c5fc198593f34aa242ac504508f023/chrome/browser/ui/views/profiles/signin_view_controller_delegate_views.h
[modify] https://crrev.com/0ac524ae54c5fc198593f34aa242ac504508f023/chrome/browser/ui/webui/signin/inline_login_handler.cc
[modify] https://crrev.com/0ac524ae54c5fc198593f34aa242ac504508f023/chrome/browser/ui/webui/signin/inline_login_handler.h
[modify] https://crrev.com/0ac524ae54c5fc198593f34aa242ac504508f023/chrome/browser/ui/webui/signin/sync_confirmation_handler.cc
[modify] https://crrev.com/0ac524ae54c5fc198593f34aa242ac504508f023/chrome/browser/ui/webui/signin/sync_confirmation_handler.h
[modify] https://crrev.com/0ac524ae54c5fc198593f34aa242ac504508f023/chrome/browser/ui/webui/signin/sync_confirmation_handler_unittest.cc

Status: Fixed (was: Assigned)

Sign in to add a comment