New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 591105 link

Starred by 1 user
Status: Verified
Owner:
fgor...@chromium.org
Closed: Mar 2016
Cc:
█ talo@chromium.org
█ rachelis@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 1
Type: Bug



Sign in to add a comment

Provide a single set of icons for offline_bolt

Project Member Reported by fgor...@chromium.org, Mar 1 2016 
Offline bolt icon has 2 flavors right now and we would like to ship less assets, which means reducing it to a single set of icons that gets tinted depending if we need to use light or dark colors. This affects how the offline bolt is displayed for incognito/themed pages.

Comment 1 by fgor...@chromium.org, Mar 1 2016

Status: Started (was: Assigned)
Patch that attempts to solve the problem: https://codereview.chromium.org/1753573005/
Project Member

Comment 2 by bugdroid1@chromium.org, Mar 7 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/a85ab8e4d88a1e32a0db232cfd946533dd49ef16

commit a85ab8e4d88a1e32a0db232cfd946533dd49ef16
Author: fgorski <fgorski@chromium.org>
Date: Mon Mar 07 18:51:42 2016

[Offline pages] Reduce the icon set for offline bolt, update colors

This patch:
* removes the assets for light offline bolt
* applies tinting to draw the bolt using the right color
* updates the colors based on UX recommendation

BUG= 591105 
R=tedchoc@chromium.org

Review URL: https://codereview.chromium.org/1753573005

Cr-Commit-Position: refs/heads/master@{#379595}

[modify] https://crrev.com/a85ab8e4d88a1e32a0db232cfd946533dd49ef16/chrome/android/java/res/drawable-hdpi/offline_bolt.png
[delete] https://crrev.com/bef7b81a0a7963afb85c932ae78b1cd72a731a41/chrome/android/java/res/drawable-hdpi/offline_bolt_light.png
[modify] https://crrev.com/a85ab8e4d88a1e32a0db232cfd946533dd49ef16/chrome/android/java/res/drawable-mdpi/offline_bolt.png
[delete] https://crrev.com/bef7b81a0a7963afb85c932ae78b1cd72a731a41/chrome/android/java/res/drawable-mdpi/offline_bolt_light.png
[modify] https://crrev.com/a85ab8e4d88a1e32a0db232cfd946533dd49ef16/chrome/android/java/res/drawable-xhdpi/offline_bolt.png
[delete] https://crrev.com/bef7b81a0a7963afb85c932ae78b1cd72a731a41/chrome/android/java/res/drawable-xhdpi/offline_bolt_light.png
[modify] https://crrev.com/a85ab8e4d88a1e32a0db232cfd946533dd49ef16/chrome/android/java/res/drawable-xxhdpi/offline_bolt.png
[delete] https://crrev.com/bef7b81a0a7963afb85c932ae78b1cd72a731a41/chrome/android/java/res/drawable-xxhdpi/offline_bolt_light.png
[modify] https://crrev.com/a85ab8e4d88a1e32a0db232cfd946533dd49ef16/chrome/android/java/res/drawable-xxxhdpi/offline_bolt.png
[delete] https://crrev.com/bef7b81a0a7963afb85c932ae78b1cd72a731a41/chrome/android/java/res/drawable-xxxhdpi/offline_bolt_light.png
[modify] https://crrev.com/a85ab8e4d88a1e32a0db232cfd946533dd49ef16/chrome/android/java/res/layout/location_bar_status.xml
[modify] https://crrev.com/a85ab8e4d88a1e32a0db232cfd946533dd49ef16/chrome/android/java/res/values/colors.xml
[modify] https://crrev.com/a85ab8e4d88a1e32a0db232cfd946533dd49ef16/chrome/android/java/src/org/chromium/chrome/browser/omnibox/LocationBarLayout.java

Comment 3 by fgor...@chromium.org, Mar 7 2016

Labels: Merge-Request-50

Comment 4 by tin...@google.com, Mar 7 2016

Labels: -Merge-Request-50 Merge-Approved-50 Hotlist-Merge-Approved
Your change meets the bar and is auto-approved for M50 (branch: 2661)
Project Member

Comment 5 by bugdroid1@chromium.org, Mar 7 2016

Labels: -merge-approved-50 merge-merged-2661
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/e4f3285c1ab237d7ac624f80665f4e5fe910b12c

commit e4f3285c1ab237d7ac624f80665f4e5fe910b12c
Author: Filip Gorski <fgorski@chromium.org>
Date: Mon Mar 07 19:01:53 2016

[Offline pages] Reduce the icon set for offline bolt, update colors

This patch:
* removes the assets for light offline bolt
* applies tinting to draw the bolt using the right color
* updates the colors based on UX recommendation

BUG= 591105 
R=tedchoc@chromium.org

Review URL: https://codereview.chromium.org/1753573005

Cr-Commit-Position: refs/heads/master@{#379595}
(cherry picked from commit a85ab8e4d88a1e32a0db232cfd946533dd49ef16)

Review URL: https://codereview.chromium.org/1773473003 .

Cr-Commit-Position: refs/branch-heads/2661@{#101}
Cr-Branched-From: ef6f6ae5e4c96622286b563658d5cd62a6cf1197-refs/heads/master@{#378081}

[modify] https://crrev.com/e4f3285c1ab237d7ac624f80665f4e5fe910b12c/chrome/android/java/res/drawable-hdpi/offline_bolt.png
[delete] https://crrev.com/60c31d822ac19c6fa9ac09aaca8917615b9e3c56/chrome/android/java/res/drawable-hdpi/offline_bolt_light.png
[modify] https://crrev.com/e4f3285c1ab237d7ac624f80665f4e5fe910b12c/chrome/android/java/res/drawable-mdpi/offline_bolt.png
[delete] https://crrev.com/60c31d822ac19c6fa9ac09aaca8917615b9e3c56/chrome/android/java/res/drawable-mdpi/offline_bolt_light.png
[modify] https://crrev.com/e4f3285c1ab237d7ac624f80665f4e5fe910b12c/chrome/android/java/res/drawable-xhdpi/offline_bolt.png
[delete] https://crrev.com/60c31d822ac19c6fa9ac09aaca8917615b9e3c56/chrome/android/java/res/drawable-xhdpi/offline_bolt_light.png
[modify] https://crrev.com/e4f3285c1ab237d7ac624f80665f4e5fe910b12c/chrome/android/java/res/drawable-xxhdpi/offline_bolt.png
[delete] https://crrev.com/60c31d822ac19c6fa9ac09aaca8917615b9e3c56/chrome/android/java/res/drawable-xxhdpi/offline_bolt_light.png
[modify] https://crrev.com/e4f3285c1ab237d7ac624f80665f4e5fe910b12c/chrome/android/java/res/drawable-xxxhdpi/offline_bolt.png
[delete] https://crrev.com/60c31d822ac19c6fa9ac09aaca8917615b9e3c56/chrome/android/java/res/drawable-xxxhdpi/offline_bolt_light.png
[modify] https://crrev.com/e4f3285c1ab237d7ac624f80665f4e5fe910b12c/chrome/android/java/res/layout/location_bar_status.xml
[modify] https://crrev.com/e4f3285c1ab237d7ac624f80665f4e5fe910b12c/chrome/android/java/res/values/colors.xml
[modify] https://crrev.com/e4f3285c1ab237d7ac624f80665f4e5fe910b12c/chrome/android/java/src/org/chromium/chrome/browser/omnibox/LocationBarLayout.java

Comment 6 by fgor...@chromium.org, Mar 7 2016

Status: Fixed (was: Started)

Comment 7 by bustamante@chromium.org, Apr 1 2016

Status: Verified (was: Fixed)
Verified.  The offline bolt icon is now used everywhere.
►

Sign in to add a comment