Page information dialog still shows http:// scheme for offline pages |
|||||||
Issue descriptionDevice: Any Android phone/tablet Steps to reproduce: 1. Enable offline pages 2. Bookmark an http:// page 3. Go offline 4. Open the newly created bookmark 5. Click on bolt icon or verbose status in the omnibox Observed behavior: Page information shows the url of the original page with http:// scheme Expected behavior: Page information shows the URL of the original page without http:// scheme How often did this happen (e.g. 1/10 times)?: all the time If possible, attach a bug report and/or screenshot. (Android settings > About Phone > tap Build number 7 times Tal, I am marking this P1 per our triage decision yesterday
,
Mar 1 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/1ffb363a1e011a850a4fbaa1f06a2cd318955a9b commit 1ffb363a1e011a850a4fbaa1f06a2cd318955a9b Author: fgorski <fgorski@chromium.org> Date: Tue Mar 01 21:34:55 2016 [Offline pages] Making sure http:// scheme is stripped from OIB BUG= 591104 Review URL: https://codereview.chromium.org/1749233003 Cr-Commit-Position: refs/heads/master@{#378563} [modify] https://crrev.com/1ffb363a1e011a850a4fbaa1f06a2cd318955a9b/chrome/android/java/src/org/chromium/chrome/browser/offlinepages/OfflinePageUtils.java [modify] https://crrev.com/1ffb363a1e011a850a4fbaa1f06a2cd318955a9b/chrome/android/java/src/org/chromium/chrome/browser/pageinfo/WebsiteSettingsPopup.java [modify] https://crrev.com/1ffb363a1e011a850a4fbaa1f06a2cd318955a9b/chrome/android/java/src/org/chromium/chrome/browser/toolbar/ToolbarModelImpl.java
,
Mar 1 2016
,
Mar 1 2016
Your change meets the bar and is auto-approved for M50 (branch: 2661)
,
Mar 1 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/eb6b378606f6b78b6a8a0654bb4295fba5ccd858 commit eb6b378606f6b78b6a8a0654bb4295fba5ccd858 Author: Filip Gorski <fgorski@chromium.org> Date: Tue Mar 01 21:57:54 2016 [Offline pages] Making sure http:// scheme is stripped from OIB BUG= 591104 R=tedchoc@chromium.org Review URL: https://codereview.chromium.org/1749233003 Cr-Commit-Position: refs/heads/master@{#378563} (cherry picked from commit 1ffb363a1e011a850a4fbaa1f06a2cd318955a9b) Review URL: https://codereview.chromium.org/1755613003 . Cr-Commit-Position: refs/branch-heads/2661@{#35} Cr-Branched-From: ef6f6ae5e4c96622286b563658d5cd62a6cf1197-refs/heads/master@{#378081} [modify] https://crrev.com/eb6b378606f6b78b6a8a0654bb4295fba5ccd858/chrome/android/java/src/org/chromium/chrome/browser/offlinepages/OfflinePageUtils.java [modify] https://crrev.com/eb6b378606f6b78b6a8a0654bb4295fba5ccd858/chrome/android/java/src/org/chromium/chrome/browser/pageinfo/WebsiteSettingsPopup.java [modify] https://crrev.com/eb6b378606f6b78b6a8a0654bb4295fba5ccd858/chrome/android/java/src/org/chromium/chrome/browser/toolbar/ToolbarModelImpl.java
,
Mar 1 2016
,
Mar 2 2016
The following revision refers to this bug: https://chrome-internal.googlesource.com/bling/chromium.git/+/1ffb363a1e011a850a4fbaa1f06a2cd318955a9b commit 1ffb363a1e011a850a4fbaa1f06a2cd318955a9b Author: fgorski <fgorski@chromium.org> Date: Tue Mar 01 21:34:55 2016
,
Mar 2 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/6a7e0f3fb4c0d0a615e4bc95378150895952cb15 commit 6a7e0f3fb4c0d0a615e4bc95378150895952cb15 Author: fgorski <fgorski@chromium.org> Date: Wed Mar 02 19:34:21 2016 [Offline pages] Adding test for OfflinePageUtils#stripSchemeFromOnlineUrl This patch adds a junit unit test for OfflinePageUtils#stripSchemeFromOnlineUrl. BUG= 591104 Review URL: https://codereview.chromium.org/1761533002 Cr-Commit-Position: refs/heads/master@{#378800} [modify] https://crrev.com/6a7e0f3fb4c0d0a615e4bc95378150895952cb15/chrome/android/java/src/org/chromium/chrome/browser/offlinepages/OfflinePageUtils.java [modify] https://crrev.com/6a7e0f3fb4c0d0a615e4bc95378150895952cb15/chrome/android/junit/src/org/chromium/chrome/browser/offlinepages/OfflinePageUtilsTest.java
,
Mar 4 2016
Verified fixed in Chrome 51.0.2667.0 |
|||||||
►
Sign in to add a comment |
|||||||
Comment 1 by fgor...@chromium.org
, Mar 1 2016