Some NetworkChangeNotifierTests fail on Android L+ Devices
Reported by
bhal...@amazon.com,
Mar 1 2016
|
|||
Issue descriptionChrome Version : Any (e.g. tip of master) What steps will reproduce the problem? On a device having android SDK L or above and active network connection. ./build/android/test_runner.py instrumentation --test-apk ContentShellTest --verbose --disable-dalvik-asserts --test_data content:content/test/data/android/device_files -f NetworkChangeNotifierTest* --num-retries=0 What is the expected result? C 10.612s Main Summary C 10.612s Main ******************************************************************************** C 10.612s Main [==========] 14 test ran. C 10.612s Main [ PASSED ] 14 test. C 10.612s Main ******************************************************************************** What happens instead? C 27.674s Main Summary C 27.675s Main ******************************************************************************** C 27.675s Main [==========] 13 test ran. C 27.675s Main [ PASSED ] 11 tests. C 27.675s Main [ FAILED ] 2 tests, listed below: C 27.675s Main [ FAILED ] org.chromium.net.NetworkChangeNotifierTest#testQueryableAPIsDoNotCrash (CRASHED) C 27.675s Main [ FAILED ] org.chromium.net.NetworkChangeNotifierTest#testNetworkChangeNotifierRegistersInConstructor (CRASHED) C 27.675s Main C 27.675s Main 2 FAILED TESTS C 27.675s Main ********************************************************************************
,
Mar 1 2016
,
Apr 26 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/3cb9af21193cd5f7d65fdac7d0b351ca97ab3669 commit 3cb9af21193cd5f7d65fdac7d0b351ca97ab3669 Author: bhallam <bhallam@amazon.com> Date: Tue Apr 26 12:37:34 2016 Fix NetworkChangeNotifierTests on Lolipop+ devices. Fixing flaky test by removing erroneous asserts in the org.chromium.net.NetworkChangeNotifierTest.TestNetworkChangeNotifierAutoDetectObserver callback implementation. On real Lollipop+ devices which have access to a real and unpredictable ConnectivityManager, the strict assertions will fail in a non-deterministic manner. Refactored one test and added one test to the suite. BUG= 591103 Review URL: https://codereview.chromium.org/1747223003 Cr-Commit-Position: refs/heads/master@{#389755} [modify] https://crrev.com/3cb9af21193cd5f7d65fdac7d0b351ca97ab3669/AUTHORS [modify] https://crrev.com/3cb9af21193cd5f7d65fdac7d0b351ca97ab3669/net/android/javatests/src/org/chromium/net/NetworkChangeNotifierTest.java
,
Apr 26 2016
|
|||
►
Sign in to add a comment |
|||
Comment 1 by bhal...@amazon.com
, Mar 1 2016