New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 591092 link

Starred by 1 user

Issue metadata

Status: Duplicate
Merged: issue 590801
Owner:
Last visit > 30 days ago
Closed: Mar 2016
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Windows
Pri: 1
Type: Bug



Sign in to add a comment

UNINITIALIZED READ in CSSVariableData no DrMemory full

Project Member Reported by osh...@chromium.org, Mar 1 2016

Issue description


Started happening on 2/26 -27 midnight
https://build.chromium.org/p/chromium.memory.fyi/builders/Windows%20Browser%20%28DrMemory%20full%29%20%281%29/builds/2760/steps/memory%20test%3A%20browser_tests_3/logs/stdio

Regression range: 378039-378114

I'll suppress it first.

### BEGIN MEMORY TOOL REPORT (error hash=#616AB0625E2A4D49#)
UNINITIALIZED READ: reading register eax
# 0 webcore_shared.dll!std::_Equal<>                                        [c:\b\depot_tools\win_toolchain\vs2013_files\4087e065abebdca6dbd0caca2910c6718d2ec67f\vc\include\xutility:2737]
# 1 webcore_shared.dll!WTF::operator==<>                                    [third_party\webkit\source\wtf\vector.h:1342]
# 2 webcore_shared.dll!blink::CSSVariableData::operator==                   [third_party\webkit\source\core\css\cssvariabledata.cpp:42]
# 3 webcore_shared.dll!blink::dataEquivalent<>                              [third_party\webkit\source\core\style\dataequivalency.h:20]
# 4 webcore_shared.dll!blink::dataEquivalent<>                              [third_party\webkit\source\core\style\dataequivalency.h:26]
# 5 webcore_shared.dll!blink::StyleVariableData::operator==                 [third_party\webkit\source\core\style\stylevariabledata.cpp:19]
# 6 webcore_shared.dll!blink::dataEquivalent<>                              [third_party\webkit\source\core\style\dataequivalency.h:20]
# 7 webcore_shared.dll!blink::dataEquivalent<>                              [third_party\webkit\source\core\style\dataequivalency.h:26]
# 8 webcore_shared.dll!blink::StyleRareInheritedData::operator==            [third_party\webkit\source\core\style\stylerareinheriteddata.cpp:233]
# 9 webcore_shared.dll!blink::DataRef<>::operator==                         [third_party\webkit\source\core\style\dataref.h:58]
#10 webcore_shared.dll!blink::ComputedStyle::operator==                     [third_party\webkit\source\core\style\computedstyle.cpp:353]
#11 webcore_shared.dll!blink::ComputedStyle::stylePropagationDiff           [third_party\webkit\source\core\style\computedstyle.cpp:196]
#12 webcore_shared.dll!blink::Element::recalcOwnStyle                       [third_party\webkit\source\core\dom\element.cpp:1748]
#13 webcore_shared.dll!blink::Element::recalcStyle                          [third_party\webkit\source\core\dom\element.cpp:1699]
#14 webcore_shared.dll!blink::ContainerNode::recalcChildStyle               [third_party\webkit\source\core\dom\containernode.cpp:1333]
#15 webcore_shared.dll!blink::ShadowRoot::recalcStyle                       [third_party\webkit\source\core\dom\shadow\shadowroot.cpp:149]
#16 webcore_shared.dll!blink::Element::recalcStyle                          [third_party\webkit\source\core\dom\element.cpp:1713]
#17 webcore_shared.dll!blink::ContainerNode::recalcChildStyle               [third_party\webkit\source\core\dom\containernode.cpp:1333]
#18 webcore_shared.dll!blink::Element::recalcStyle                          [third_party\webkit\source\core\dom\element.cpp:1715]
#19 webcore_shared.dll!blink::ContainerNode::recalcChildStyle               [third_party\webkit\source\core\dom\containernode.cpp:1333]
#20 webcore_shared.dll!blink::ShadowRoot::recalcStyle                       [third_party\webkit\source\core\dom\shadow\shadowroot.cpp:149]
#21 webcore_shared.dll!blink::Element::recalcStyle                          [third_party\webkit\source\core\dom\element.cpp:1713]
#22 webcore_shared.dll!blink::ContainerNode::recalcChildStyle               [third_party\webkit\source\core\dom\containernode.cpp:1333]
#23 webcore_shared.dll!blink::Element::recalcStyle                          [third_party\webkit\source\core\dom\element.cpp:1715]
#24 webcore_shared.dll!blink::ContainerNode::recalcChildStyle               [third_party\webkit\source\core\dom\containernode.cpp:1333]
#25 webcore_shared.dll!blink::ShadowRoot::recalcStyle                       [third_party\webkit\source\core\dom\shadow\shadowroot.cpp:149]
#26 webcore_shared.dll!blink::Element::recalcStyle                          [third_party\webkit\source\core\dom\element.cpp:1713]
#27 webcore_shared.dll!blink::ContainerNode::recalcChildStyle               [third_party\webkit\source\core\dom\containernode.cpp:1333]
#28 webcore_shared.dll!blink::Element::recalcStyle                          [third_party\webkit\source\core\dom\element.cpp:1715]
#29 webcore_shared.dll!blink::ContainerNode::recalcChildStyle               [third_party\webkit\source\core\dom\containernode.cpp:1333]
#30 webcore_shared.dll!blink::Element::recalcStyle                          [third_party\webkit\source\core\dom\element.cpp:1715]
#31 webcore_shared.dll!blink::Document::updateStyle                         [third_party\webkit\source\core\dom\document.cpp:1852]
#32 webcore_shared.dll!blink::Document::updateLayoutTree                    [third_party\webkit\source\core\dom\document.cpp:1786]
#33 webcore_shared.dll!blink::Document::updateLayoutTreeIgnorePendingStylesheets [third_party\webkit\source\core\dom\document.cpp:2024]
#34 webcore_shared.dll!blink::Document::updateLayoutIgnorePendingStylesheets [third_party\webkit\source\core\dom\document.cpp:2029]
#35 webcore_shared.dll!blink::Element::offsetWidth                          [third_party\webkit\source\core\dom\element.cpp:630]
#36 webcore_shared.dll!blink::HTMLElementV8Internal::offsetWidthAttributeGetter [out\release\gen\blink\bindings\core\v8\v8htmlelement.cpp:468]
#37 v8.dll!v8::internal::`anonymous namespace'::Invoke                      [v8\src\execution.cc:98]
#38 v8.dll!v8::internal::Execution::Call                                    [v8\src\execution.cc:164]
#39 v8.dll!v8::internal::Execution::TryCall                                 [v8\src\execution.cc:201]
 
Project Member

Comment 1 by bugdroid1@chromium.org, Mar 1 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/72092f24d6f67c16b6810d310615228d31d3a075

commit 72092f24d6f67c16b6810d310615228d31d3a075
Author: oshima <oshima@chromium.org>
Date: Tue Mar 01 18:01:00 2016

Suppress UNINITIALIZED_READ in CSSVariableData

BUG= 591092 
TBR=benwells@chromium.org

Review URL: https://codereview.chromium.org/1753833002

Cr-Commit-Position: refs/heads/master@{#378470}

[modify] https://crrev.com/72092f24d6f67c16b6810d310615228d31d3a075/tools/valgrind/drmemory/suppressions_full.txt

Comment 2 by shans@chromium.org, Mar 1 2016

Components: -Blink>Memory

Comment 3 by shans@chromium.org, Mar 1 2016

Labels: -Pri-2 Pri-1
Owner: shans@chromium.org
Status: Assigned (was: Untriaged)
Mergedinto: 590801
Status: Duplicate (was: Assigned)
Project Member

Comment 5 by bugdroid1@chromium.org, Mar 2 2016

Labels: Merge-Merged-master1
The following revision refers to this bug:
  https://chrome-internal.googlesource.com/bling/chromium.git/+/72092f24d6f67c16b6810d310615228d31d3a075

commit 72092f24d6f67c16b6810d310615228d31d3a075
Author: oshima <oshima@chromium.org>
Date: Tue Mar 01 18:01:00 2016

Project Member

Comment 6 by bugdroid1@chromium.org, May 6 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/6988d5badc6ee8330101e9dd21a92405672a05be

commit 6988d5badc6ee8330101e9dd21a92405672a05be
Author: timloh <timloh@chromium.org>
Date: Fri May 06 00:43:54 2016

Retire some memcheck and Dr. Memory suppressions for CSS code

This patch removes several suppressions for memcheck and Dr. Memory:

343797, 343915: The Bison CSS parser no longer exists ( crbug.com/489144 )
492821: The CSS property parser has been rewritten ( crbug.com/499780 )
591092: This bug has been fixed ( crbug.com/590801 )

BUG= 343797 ,  343915 ,  492821 ,  591092 

Review-Url: https://codereview.chromium.org/1950563004
Cr-Commit-Position: refs/heads/master@{#391970}

[modify] https://crrev.com/6988d5badc6ee8330101e9dd21a92405672a05be/tools/valgrind/drmemory/suppressions_full.txt
[modify] https://crrev.com/6988d5badc6ee8330101e9dd21a92405672a05be/tools/valgrind/memcheck/suppressions.txt

Sign in to add a comment