New issue
Advanced search Search tips

Issue 591089 link

Starred by 3 users

Issue metadata

Status: Started
Owner:
Components:
EstimatedDays: ----
NextAction: ----
OS: All
Pri: 2
Type: Bug



Sign in to add a comment

Implement algorithm for setting AudioBufferSource.buffer

Project Member Reported by rtoy@chromium.org, Mar 1 2016

Issue description

Implement the algorithm for setting AudioBufferSource.buffer as given in https://github.com/WebAudio/web-audio-api/pull/743
 

Comment 1 by rtoy@chromium.org, Mar 1 2016

Owner: rtoy@chromium.org
Status: Assigned (was: Available)

Comment 2 by rtoy@chromium.org, Mar 1 2016

Status: Started (was: Assigned)
Project Member

Comment 3 by bugdroid1@chromium.org, Aug 1 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/1ef23c62889c7c9fa4c93999a364c6939bf4da92

commit 1ef23c62889c7c9fa4c93999a364c6939bf4da92
Author: rtoy <rtoy@chromium.org>
Date: Tue Aug 01 16:09:41 2017

Make AudioBufferSourceNode.buffer setter conforming

Make ABSN.buffer setter conform to the spec.  We were already throwing
errors on attempts to set the buffer twice.  To conform, we need to
allow setting the buffer to null, but still throwing an error if the
buffer was ever set to a non-null value.

BUG=591089
TEST=AudioBufferSource/audiobuffersource-channels.html

Review-Url: https://codereview.chromium.org/2842003003
Cr-Commit-Position: refs/heads/master@{#491003}

[modify] https://crrev.com/1ef23c62889c7c9fa4c93999a364c6939bf4da92/third_party/WebKit/LayoutTests/webaudio/AudioBufferSource/audiobuffersource-channels.html
[modify] https://crrev.com/1ef23c62889c7c9fa4c93999a364c6939bf4da92/third_party/WebKit/LayoutTests/webaudio/dom-exceptions-expected.txt
[modify] https://crrev.com/1ef23c62889c7c9fa4c93999a364c6939bf4da92/third_party/WebKit/Source/modules/webaudio/AudioBufferSourceNode.cpp
[modify] https://crrev.com/1ef23c62889c7c9fa4c93999a364c6939bf4da92/third_party/WebKit/Source/modules/webaudio/AudioBufferSourceNode.h
[modify] https://crrev.com/1ef23c62889c7c9fa4c93999a364c6939bf4da92/third_party/WebKit/Source/modules/webaudio/AudioBufferSourceNode.idl

Sign in to add a comment