New issue
Advanced search Search tips

Issue 591079 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Mar 2016
Components:
EstimatedDays: ----
NextAction: ----
OS: All
Pri: 2
Type: Bug



Sign in to add a comment

Remove dependency from ResourceFetcher::preCacheData() to MemoryCache

Project Member Reported by hirosh...@chromium.org, Mar 1 2016

Issue description

Resource for static data (data URLs or SubstituteData) are created
and added to MemoryCache in ResourceFetcher::preCacheData(), and then looked
up from MemoryCache.
However, putting Resource to MemoryCache is not always necessary.
I'm planning to make ResourceFetcher::preCacheData() to work without MemoryCache, and not to put Resource to MemoryCache if not necessary.

 
Project Member

Comment 1 by bugdroid1@chromium.org, Mar 1 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/7fdc1e4512c4aeeb39415656da42fbc67d2a94e6

commit 7fdc1e4512c4aeeb39415656da42fbc67d2a94e6
Author: hiroshige <hiroshige@chromium.org>
Date: Tue Mar 01 18:20:59 2016

Make ResourceFetcher not to rely on MemoryCache to serve static data

Previously, Resource for static data (data URLs or SubstituteData) are created
and added to MemoryCache in ResourceFetcher::preCacheData(), and then looked
up from MemoryCache.

This CL passes Resource created there as the return value, not via MemoryCache.
This CL also renames preCacheData() to resourceForStaticData().

This CL doesn't change the behavior because resourceForStaticData() still
always adds newly created Resource to MemoryCache.

BUG= 591079 , 382170

Review URL: https://codereview.chromium.org/1747833003

Cr-Commit-Position: refs/heads/master@{#378483}

[modify] https://crrev.com/7fdc1e4512c4aeeb39415656da42fbc67d2a94e6/third_party/WebKit/Source/core/fetch/ResourceFetcher.cpp
[modify] https://crrev.com/7fdc1e4512c4aeeb39415656da42fbc67d2a94e6/third_party/WebKit/Source/core/fetch/ResourceFetcher.h

Project Member

Comment 2 by bugdroid1@chromium.org, Mar 2 2016

Labels: Merge-Merged-master1
The following revision refers to this bug:
  https://chrome-internal.googlesource.com/bling/chromium.git/+/7fdc1e4512c4aeeb39415656da42fbc67d2a94e6

commit 7fdc1e4512c4aeeb39415656da42fbc67d2a94e6
Author: hiroshige <hiroshige@chromium.org>
Date: Tue Mar 01 18:20:59 2016

Status: Fixed (was: Started)

Sign in to add a comment