New issue
Advanced search Search tips

Issue 591074 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Oct 2016
EstimatedDays: ----
NextAction: ----
OS: Linux
Pri: 3
Type: Bug



Sign in to add a comment

Blimp cleanup: consider renaming "client_token" to "auth_token"

Project Member Reported by kmarshall@chromium.org, Mar 1 2016

Issue description

wez@ suggested renaming Assignment::client_token to "auth_token" as a cleanup task in cl/1696563002. Making the naming change consistent across the codebase will touch a lot of files and deserves its own CL.
 

Comment 1 by amin...@google.com, Mar 24 2016

Components: Mobile>Blimp
Labels: -Proj-Blimp

Comment 2 by dah...@chromium.org, Mar 31 2016

Components: -Mobile>Blimp Mobile>Blimp>Engine
Labels: -Pri-2 OS-Linux Pri-3
Status: Available (was: Untriaged)
Project Member

Comment 3 by bugdroid1@chromium.org, Sep 2 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/6be513e0c4924679cdf1b6a32f1b1b60b167e6e0

commit 6be513e0c4924679cdf1b6a32f1b1b60b167e6e0
Author: lethalantidote <lethalantidote@chromium.org>
Date: Fri Sep 02 00:38:02 2016

Changes client_token to be client_auth_token.

Renames client_token to client_auth_token. Compromise between Chromium naming and blimp_service.proto naming.

Will add changes to effect logging and test_client_token path once this rename is approved.

R=kylechar@chromium.org,piman@chromium.org,sievers@chromium.org, maniscalco@chromium.org
CC=wez@chromium.org,lethalantidote@chromium.org
BUG= 591074 

Review-Url: https://codereview.chromium.org/2281783002
Cr-Commit-Position: refs/heads/master@{#416146}

[modify] https://crrev.com/6be513e0c4924679cdf1b6a32f1b1b60b167e6e0/blimp/client/core/session/assignment_source.cc
[modify] https://crrev.com/6be513e0c4924679cdf1b6a32f1b1b60b167e6e0/blimp/client/core/session/assignment_source_unittest.cc
[modify] https://crrev.com/6be513e0c4924679cdf1b6a32f1b1b60b167e6e0/blimp/client/core/session/client_network_components.cc
[modify] https://crrev.com/6be513e0c4924679cdf1b6a32f1b1b60b167e6e0/blimp/client/public/session/assignment.h
[modify] https://crrev.com/6be513e0c4924679cdf1b6a32f1b1b60b167e6e0/blimp/common/BUILD.gn
[modify] https://crrev.com/6be513e0c4924679cdf1b6a32f1b1b60b167e6e0/blimp/common/create_blimp_message.cc
[modify] https://crrev.com/6be513e0c4924679cdf1b6a32f1b1b60b167e6e0/blimp/common/create_blimp_message.h
[modify] https://crrev.com/6be513e0c4924679cdf1b6a32f1b1b60b167e6e0/blimp/common/create_blimp_message_unittest.cc
[rename] https://crrev.com/6be513e0c4924679cdf1b6a32f1b1b60b167e6e0/blimp/common/get_client_auth_token.cc
[add] https://crrev.com/6be513e0c4924679cdf1b6a32f1b1b60b167e6e0/blimp/common/get_client_auth_token.h
[delete] https://crrev.com/e04953825cdf60e28f4b3a7207b4d30cfcb633b7/blimp/common/get_client_token.h
[modify] https://crrev.com/6be513e0c4924679cdf1b6a32f1b1b60b167e6e0/blimp/common/logging.cc
[modify] https://crrev.com/6be513e0c4924679cdf1b6a32f1b1b60b167e6e0/blimp/common/logging_unittest.cc
[modify] https://crrev.com/6be513e0c4924679cdf1b6a32f1b1b60b167e6e0/blimp/common/proto/protocol_control.proto
[modify] https://crrev.com/6be513e0c4924679cdf1b6a32f1b1b60b167e6e0/blimp/common/switches.cc
[modify] https://crrev.com/6be513e0c4924679cdf1b6a32f1b1b60b167e6e0/blimp/common/switches.h
[modify] https://crrev.com/6be513e0c4924679cdf1b6a32f1b1b60b167e6e0/blimp/engine/app/blimp_engine_config.cc
[modify] https://crrev.com/6be513e0c4924679cdf1b6a32f1b1b60b167e6e0/blimp/engine/app/blimp_engine_config.h
[modify] https://crrev.com/6be513e0c4924679cdf1b6a32f1b1b60b167e6e0/blimp/engine/app/blimp_engine_config_unittest.cc
[modify] https://crrev.com/6be513e0c4924679cdf1b6a32f1b1b60b167e6e0/blimp/engine/browser_tests/blimp_browser_test.cc
[modify] https://crrev.com/6be513e0c4924679cdf1b6a32f1b1b60b167e6e0/blimp/engine/session/blimp_engine_session.cc
[modify] https://crrev.com/6be513e0c4924679cdf1b6a32f1b1b60b167e6e0/blimp/net/client_connection_manager.cc
[modify] https://crrev.com/6be513e0c4924679cdf1b6a32f1b1b60b167e6e0/blimp/net/client_connection_manager.h
[modify] https://crrev.com/6be513e0c4924679cdf1b6a32f1b1b60b167e6e0/blimp/net/client_connection_manager_unittest.cc
[modify] https://crrev.com/6be513e0c4924679cdf1b6a32f1b1b60b167e6e0/blimp/net/engine_authentication_handler.cc
[modify] https://crrev.com/6be513e0c4924679cdf1b6a32f1b1b60b167e6e0/blimp/net/engine_authentication_handler.h
[modify] https://crrev.com/6be513e0c4924679cdf1b6a32f1b1b60b167e6e0/blimp/net/engine_authentication_handler_unittest.cc

Should I bother with things like logging and the test_client_token path? Some of the discussion on the CL made it a bit unclear. 
Status: Started (was: Assigned)
Status: Fixed (was: Started)
Labels: Archive-Blimp

Sign in to add a comment