New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 591072 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Last visit > 30 days ago
Closed: Mar 2016
Cc:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug



Sign in to add a comment

blink::WebWidget::willStartLiveResize is dead and should be removed

Project Member Reported by markdittmer@chromium.org, Mar 1 2016

Issue description

All blink::WebWidget::willStartLiveResize implementations are as follows:

blink::WebWidget::willStartLiveResize (never called)
blink::WebFrameWidgetImpl::willStartLiveResize (never called)
blink::WebViewFrameWidget::willStartLiveResize (never called)
blink::WebViewImpl::willStartLiveResize

The last of these is only called by blink::WebViewFrameWidget::willStartLiveResize, which is never called.
 
Status: Assigned (was: Untriaged)
Components: -Blink Blink>API
Project Member

Comment 3 by bugdroid1@chromium.org, Mar 7 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/44439a046d6eb17a539cfbce0fbfc9c11b7789c8

commit 44439a046d6eb17a539cfbce0fbfc9c11b7789c8
Author: markdittmer <markdittmer@chromium.org>
Date: Mon Mar 07 17:09:41 2016

Eliminate uncalled will___LiveResize and inLiveResize from RenderViewImpl through WebWidget down to scroll handlers and ImageQualityTester

This dead code was discovered while analyzing willStartLiveResize callers.

From bug:

All blink::WebWidget::willStartLiveResize implementations are as follows:

blink::WebWidget::willStartLiveResize (never called)
blink::WebFrameWidgetImpl::willStartLiveResize (never called)
blink::WebViewFrameWidget::willStartLiveResize (never called)
blink::WebViewImpl::willStartLiveResize

The last of these is only called by blink::WebViewFrameWidget::willStartLiveResize, which is never called.

Naturally, eliminating willStartLiveResize drills into other methods (like willEndLiveResize) and state (that tracks whether currently live resizing).

BUG= 591072 

Review URL: https://codereview.chromium.org/1749383002

Cr-Commit-Position: refs/heads/master@{#379568}

[modify] https://crrev.com/44439a046d6eb17a539cfbce0fbfc9c11b7789c8/content/browser/renderer_host/render_widget_host_view_mac.mm
[modify] https://crrev.com/44439a046d6eb17a539cfbce0fbfc9c11b7789c8/content/common/view_messages.h
[modify] https://crrev.com/44439a046d6eb17a539cfbce0fbfc9c11b7789c8/content/renderer/render_view_impl.cc
[modify] https://crrev.com/44439a046d6eb17a539cfbce0fbfc9c11b7789c8/content/renderer/render_view_impl.h
[modify] https://crrev.com/44439a046d6eb17a539cfbce0fbfc9c11b7789c8/third_party/WebKit/Source/core/layout/ImageQualityController.cpp
[modify] https://crrev.com/44439a046d6eb17a539cfbce0fbfc9c11b7789c8/third_party/WebKit/Source/core/layout/ImageQualityController.h
[modify] https://crrev.com/44439a046d6eb17a539cfbce0fbfc9c11b7789c8/third_party/WebKit/Source/core/layout/ImageQualityControllerTest.cpp
[modify] https://crrev.com/44439a046d6eb17a539cfbce0fbfc9c11b7789c8/third_party/WebKit/Source/platform/mac/ScrollAnimatorMac.h
[modify] https://crrev.com/44439a046d6eb17a539cfbce0fbfc9c11b7789c8/third_party/WebKit/Source/platform/mac/ScrollAnimatorMac.mm
[modify] https://crrev.com/44439a046d6eb17a539cfbce0fbfc9c11b7789c8/third_party/WebKit/Source/platform/scroll/ScrollAnimatorBase.h
[modify] https://crrev.com/44439a046d6eb17a539cfbce0fbfc9c11b7789c8/third_party/WebKit/Source/platform/scroll/ScrollableArea.cpp
[modify] https://crrev.com/44439a046d6eb17a539cfbce0fbfc9c11b7789c8/third_party/WebKit/Source/platform/scroll/ScrollableArea.h
[modify] https://crrev.com/44439a046d6eb17a539cfbce0fbfc9c11b7789c8/third_party/WebKit/Source/web/WebFrameWidgetImpl.cpp
[modify] https://crrev.com/44439a046d6eb17a539cfbce0fbfc9c11b7789c8/third_party/WebKit/Source/web/WebFrameWidgetImpl.h
[modify] https://crrev.com/44439a046d6eb17a539cfbce0fbfc9c11b7789c8/third_party/WebKit/Source/web/WebViewFrameWidget.cpp
[modify] https://crrev.com/44439a046d6eb17a539cfbce0fbfc9c11b7789c8/third_party/WebKit/Source/web/WebViewFrameWidget.h
[modify] https://crrev.com/44439a046d6eb17a539cfbce0fbfc9c11b7789c8/third_party/WebKit/Source/web/WebViewImpl.cpp
[modify] https://crrev.com/44439a046d6eb17a539cfbce0fbfc9c11b7789c8/third_party/WebKit/Source/web/WebViewImpl.h
[modify] https://crrev.com/44439a046d6eb17a539cfbce0fbfc9c11b7789c8/third_party/WebKit/public/web/WebWidget.h

Status: Fixed (was: Assigned)

Sign in to add a comment