New issue
Advanced search Search tips

Issue 591058 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Dec 2016
Components:
EstimatedDays: ----
NextAction: ----
OS: All
Pri: 2
Type: Bug



Sign in to add a comment

Chrome autocompletes login into Fandango signup form, and not login form.

Project Member Reported by rsch...@chromium.org, Mar 1 2016

Issue description

Chrome Version       : 49.0.2623.59
OS Version: 7834.42.0
URLs (if applicable) : https://tickets.fandango.com/transaction/ticketing/express/Checkout.aspx?wssaffid=11584_GoogleMoviesOneBox(Web)   (essentially, be buying a ticket)


The Fandango checkout form starts out suggesting you sign up. Chrome autofills this with my current username and password: https://screenshot.googleplex.com/eqXN4FwRnCE

If you instead choose to sign in, the password field is now missing its autofill, even though username appears to work just fine: https://screenshot.googleplex.com/bd2A4htBAvW

The autofilled signup field is: <input name="ExpressWebCheckout$CreateAccountView$createPasswordInput" type="password" id="createPasswordInput" class="createAccount input inline-block">

The not autofilled login field is: <input class="input user inlineBlock inline" type="password" id="fandangoPassword" title="password">

 

Comment 1 by ma...@chromium.org, Mar 1 2016

Components: -UI>Browser>Autofill UI>Browser>Passwords
Owner: dvadym@chromium.org
Status: Assigned (was: Unconfirmed)
Summary: Chrome autocompletes login into Fandango signup form, and not login form. (was: Chrome autocompletes login into Fandango login form, and not signup form.)
Typo in the summary, fixed.
Labels: -OS-Chrome OS-All
Thanks for report!

The problem is that there are actually two forms in a one <form> element, for sign-in and for sign-up. The password elements are different, but username element is the same. Our current logic is to match username element with only one password element, so we fill only Sign-Up password. I'm currently working on improvement of our password autofill logic, and it should cover this case.

Comment 4 by vabr@chromium.org, Mar 8 2016

Labels: Hotlist-Polish
Project Member

Comment 5 by bugdroid1@chromium.org, Apr 8 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/20e808ba94aa4a1ff5d3c16155f86bf93747de42

commit 20e808ba94aa4a1ff5d3c16155f86bf93747de42
Author: dvadym <dvadym@chromium.org>
Date: Fri Apr 08 17:20:36 2016

Better filling on suggestion of password fields in Password Manager.

There are a lot of reasons why PasswordManager could miss a password field for autofilling, for example when there is an invisible dummy password field and it's autofilled instead of correct one. This patch makes that as soon as the user clicks on password field Password Manager will show suggestion dropdown with credentials that are already fetched from store in PasswordFormManager (if this is not enough, we'll need to add fetching credentials, but now it looks as adding non-necessary complexity). So as consequence of this patch Password Manager will show more suggestions on password fields, probably sometimes in cases where it shouldn't.

Precise logic of showing suggestion on password field is the following: A suggestion dropdown is shown on any password field until the user chooses one of the suggestion on some password field, then a suggestion is shown only on this field.

The latter part is made for decreasing number of false positives. For example if there is a change password form with <old password field> and <new password field>, initially suggestions will be shown on clicking on both of them, but as soon as the user accepts it for <old passoword field> it will be not shown for <new password field>.

BUG= 597304 ,  591058 

Review URL: https://codereview.chromium.org/1814193002

Cr-Commit-Position: refs/heads/master@{#386109}

[modify] https://crrev.com/20e808ba94aa4a1ff5d3c16155f86bf93747de42/chrome/renderer/autofill/password_autofill_agent_browsertest.cc
[modify] https://crrev.com/20e808ba94aa4a1ff5d3c16155f86bf93747de42/components/autofill/content/renderer/password_autofill_agent.cc
[modify] https://crrev.com/20e808ba94aa4a1ff5d3c16155f86bf93747de42/components/autofill/content/renderer/password_autofill_agent.h

Comment 6 by kolos@chromium.org, Dec 15 2016

Status: Fixed (was: Assigned)

Sign in to add a comment