New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 591057 link

Starred by 4 users
Status: Fixed
Owner:
█ shrike@chromium.org
Last visit > 30 days ago
Closed: Mar 2016
Cc:
pkasting@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Mac
Pri: 2
Type: Bug



Sign in to add a comment

Themed inactive tabs are not colored correctly

Project Member Reported by rsesek@chromium.org, Mar 1 2016 
Version: 51.0.2664.0
OS: 10.11.3

What steps will reproduce the problem?
1. Install https://chrome.google.com/webstore/detail/greyscale/olagifopidokilmoeiiejpmpfclmopfk
2. Open multiple tabs
3. Inactive tabs are the wrong color, both when the window is active and when it is inactive

What is the expected output? What do you see instead?
See screenshot for current state. This is basically the same as  issue 585867 . See that bug for how the tabs should look.

Please use labels and text to provide additional information.
Screen Shot 2016-03-01 at 9.43.36 AM.png
40.0 KB View Download

Comment 1 by shrike@chromium.org, Mar 1 2016

Status: Started (was: Assigned)
Project Member

Comment 2 by bugdroid1@chromium.org, Mar 2 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/1ce82ea96b06b419a7c82090cd4c561d6bb11da4

commit 1ce82ea96b06b419a7c82090cd4c561d6bb11da4
Author: shrike <shrike@chromium.org>
Date: Wed Mar 02 17:35:19 2016

Fix regression in background tab color (Mac).

When merging my Material Design changes for the Mac tab strip I mis-
merged this one important change, part of the fix for the regression
in  crbug.com/585867 .

BUG= 591057 

Review URL: https://codereview.chromium.org/1756643002

Cr-Commit-Position: refs/heads/master@{#378768}

[modify] https://crrev.com/1ce82ea96b06b419a7c82090cd4c561d6bb11da4/chrome/browser/themes/theme_properties.cc

Comment 3 by shrike@chromium.org, Mar 2 2016

Status: Fixed (was: Started)

Comment 4 by rsesek@chromium.org, Mar 4 2016 

I'm still seeing this in today's canary 51.0.2667.0.

Comment 5 by shrike@chromium.org, Mar 4 2016 

It's working for me in 51.0.2667.0 (see screenshot). You mentioned in the crbug/585867 that theme images are cached, so perhaps you're just seeing old images from the cache?
Screen Shot 2016-03-04 at 10.12.29 AM.png
64.7 KB View Download

Comment 6 by rsesek@chromium.org, Mar 4 2016 

Ah, yes, if I reinstall the theme it works.

Comment 7 by ijpedowitz@google.com, Mar 14 2016 

Friendly ping?  When will this go live?  I am still seeing this on 51.0.2673.0 (Official Build) canary (64-bit) on Mac OS X 10.11.3

Comment 8 by shrike@chromium.org, Mar 14 2016 

This is already live and confirmed fixed. Please be sure to empty your cache.

Comment 9 by rsesek@chromium.org, Mar 14 2016 

In https://chromium.googlesource.com/chromium/src.git/+/954f76a1bde641fc6331167282fd91e2697a7993%5E%21/#F0, the CL also bumped the theme pack version to invalidate the cache. Maybe we should do that for this.

Comment 10 by ijpedowitz@google.com, Mar 15 2016 

So should this be reopened to implement the invalidation?

Comment 11 by shrike@chromium.org, Mar 15 2016 

> So should this be reopened to implement the invalidation?

No - I have filed  bug 594892  for that.
►

Sign in to add a comment