Issue metadata
Sign in to add a comment
|
Regression: 'Exit' option is vanish from wrench after extension pop-up opened.
Reported by
dmascare...@etouch.net,
Mar 1 2016
|
||||||||||||||||||||||
Issue descriptionChrome Version:50.0.2661.5 c836bc532e4bd4bacb0be5bb10efd493b0057679-refs/branch-heads/2661@{#19} 32/64 bit Os: Windows (Win 7 Aero enabled) Pre-condition:1. Enable extension toolbar redesign flag. 2. Install 9-10 extension , two extension icon seen in browser action container and remaining in the wrench. What steps will reproduce the problem? 1. Launch chrome and open wrench, click on one extension icon such that pop-up opens (as shown in video) (e.g 'Google Calendar' extension) 2. Click on wrench and observe the 'Exit' option. Actual: 'Exit' option is not seen after step 2. Expected: 'Exit option should be seen This is regression issue,broken in 'M 48' and below is Changelog: https://chromium.googlesource.com/chromium/src/+log/48.0.2544.0..48.0.2546.0?pretty=fuller&n=10000 Suspecting: r355847 ? Good build: 48.0.2544.0 Bad build: 48.0.2546.0 Note: Above issue is not reproducible on Mac ,Linux OS.
,
Mar 3 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/f3f1fd9a78e963f3068d7eb46a66e4ff40348f4b commit f3f1fd9a78e963f3068d7eb46a66e4ff40348f4b Author: rdevlin.cronin <rdevlin.cronin@chromium.org> Date: Thu Mar 03 18:00:05 2016 [Extensions UI Views] Adjust the wrench menu actions for items added/removed Extension items can be added or removed to the wrench menu while it is open (if, for instance, a popup closes and slides the item back in, or, more rarely, the extension is only just added, crashes, etc). In rare cases, this can result in the container needing to add or remove a row, which means the rest of the menu's height needs to adjust. BUG= 591028 Review URL: https://codereview.chromium.org/1757993003 Cr-Commit-Position: refs/heads/master@{#379035} [modify] https://crrev.com/f3f1fd9a78e963f3068d7eb46a66e4ff40348f4b/chrome/browser/ui/views/toolbar/app_menu.cc [modify] https://crrev.com/f3f1fd9a78e963f3068d7eb46a66e4ff40348f4b/chrome/browser/ui/views/toolbar/extension_toolbar_menu_view.cc [modify] https://crrev.com/f3f1fd9a78e963f3068d7eb46a66e4ff40348f4b/chrome/browser/ui/views/toolbar/extension_toolbar_menu_view.h
,
Mar 3 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/f3f1fd9a78e963f3068d7eb46a66e4ff40348f4b commit f3f1fd9a78e963f3068d7eb46a66e4ff40348f4b Author: rdevlin.cronin <rdevlin.cronin@chromium.org> Date: Thu Mar 03 18:00:05 2016 [Extensions UI Views] Adjust the wrench menu actions for items added/removed Extension items can be added or removed to the wrench menu while it is open (if, for instance, a popup closes and slides the item back in, or, more rarely, the extension is only just added, crashes, etc). In rare cases, this can result in the container needing to add or remove a row, which means the rest of the menu's height needs to adjust. BUG= 591028 Review URL: https://codereview.chromium.org/1757993003 Cr-Commit-Position: refs/heads/master@{#379035} [modify] https://crrev.com/f3f1fd9a78e963f3068d7eb46a66e4ff40348f4b/chrome/browser/ui/views/toolbar/app_menu.cc [modify] https://crrev.com/f3f1fd9a78e963f3068d7eb46a66e4ff40348f4b/chrome/browser/ui/views/toolbar/extension_toolbar_menu_view.cc [modify] https://crrev.com/f3f1fd9a78e963f3068d7eb46a66e4ff40348f4b/chrome/browser/ui/views/toolbar/extension_toolbar_menu_view.h
,
Mar 4 2016
,
Mar 4 2016
Your change meets the bar and is auto-approved for M50 (branch: 2661)
,
Mar 4 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/94da142c673729d277c271134754d82677eefa93 commit 94da142c673729d277c271134754d82677eefa93 Author: Devlin Cronin <rdevlin.cronin@chromium.org> Date: Fri Mar 04 20:08:44 2016 [Extensions UI Views] Adjust the wrench menu actions for items added/removed Extension items can be added or removed to the wrench menu while it is open (if, for instance, a popup closes and slides the item back in, or, more rarely, the extension is only just added, crashes, etc). In rare cases, this can result in the container needing to add or remove a row, which means the rest of the menu's height needs to adjust. BUG= 591028 Review URL: https://codereview.chromium.org/1757993003 Cr-Commit-Position: refs/heads/master@{#379035} (cherry picked from commit f3f1fd9a78e963f3068d7eb46a66e4ff40348f4b) Review URL: https://codereview.chromium.org/1766023002 . Cr-Commit-Position: refs/branch-heads/2661@{#82} Cr-Branched-From: ef6f6ae5e4c96622286b563658d5cd62a6cf1197-refs/heads/master@{#378081} [modify] https://crrev.com/94da142c673729d277c271134754d82677eefa93/chrome/browser/ui/views/toolbar/app_menu.cc [modify] https://crrev.com/94da142c673729d277c271134754d82677eefa93/chrome/browser/ui/views/toolbar/extension_toolbar_menu_view.cc [modify] https://crrev.com/94da142c673729d277c271134754d82677eefa93/chrome/browser/ui/views/toolbar/extension_toolbar_menu_view.h
,
Mar 8 2016
Fix is working as intended. Rechecked on Win 7, Win 8.1 for chrome version: 50.0.2661.18 and adding TE-verified labels. |
|||||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||||
Comment 1 by ranjitkan@chromium.org
, Mar 1 2016