Issue metadata
Sign in to add a comment
|
Regression: Text misalignment issue is seen for all the buttons on ’chrome://settings' page.
Reported by
dchau...@etouch.net,
Mar 1 2016
|
||||||||||||||||||||||
Issue descriptionChrome Version: 50.0.2661.5 c836bc532e4bd4bacb0be5bb10efd493b0057679-refs/branch-heads/2661@{#19} OS: Mac What steps will reproduce the problem? 1. Launch chrome and navigate to chrome://settings/importData 2. Change the ‘From’ drop-down list to ‘Mozilla Firefox’ and observe. Texts are not vertically centre aligned in ‘From’ drop-down list. Texts should vertically centre align in ‘From' drop-down list. This is a regression issue, broken in M-50 series, below is bisect info. Good build: 50.0.2655.0 Bad build: 50.0.2656.0 Narrow bisect: https://chromium.googlesource.com/chromium/src/+log/791e5860824e84a15ae8e440390a6fd9bd40e52f..a0cc3019c5178b0b14c561d89c4d65845deb5da5?pretty=fuller&n=50 Suspecting: r376674 Note: 1. This issue is also seen for all the buttons on ’Settings’ page. 2. This issue is not seen on Windows and Linux OS. Kindly review the attached screenshot for reference.
,
Mar 3 2016
Basically this is an intentional change. But we might be able to improve it. I don't think this is a release blocker. Very trivial cosmetic issue.
,
Mar 3 2016
,
Mar 3 2016
This is not a Blink bug.
,
Mar 3 2016
I defer to you since I'm not Blink-knowledgeable. But I'm wondering, if crrev.com/1474233002 has undesirable/unexpected impacts on our WebUI, won't it also impact the rest of the web?
,
Mar 3 2016
crrev.com/1474233002 fixed a browser-compatibility issue. So, it affects Chrome-only pages like chrome://settings, and sites which has Chrome-only workaround.
,
Mar 4 2016
I agree with tkent
it was a bug that -webkit-appearance: none; didn't zero out the padding before (and he fixed this).
can we just add something like:
select {
padding: <previous_legacy_padding>;
}
to widgets.css[1]?
[1] https://code.google.com/p/chromium/codesearch#chromium/src/ui/webui/resources/css/widgets.css&q=select%20%5C-webkit%5C-appearance%20none&sq=package:chromium&type=cs&l=36
,
Mar 4 2016
> can we just add something like: It's done by crrev.com/363594. So we don't have any problems on Windows and Linux. crrev.com/363594 unexpectedly changed OSX behavior, and crrev.com/376674 tried to fix it because I thought reverting crrev.com/363594 was worse. Before crrev.com/363594, alignment of SELECT and buttons was broken on OSX.
,
Jun 24 2016
This issue will be gone by md-settings. |
|||||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||||
Comment 1 by ranjitkan@chromium.org
, Mar 1 2016