New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 591022 link

Starred by 1 user

Issue metadata

Status: WontFix
Owner:
Last visit > 30 days ago
Closed: Mar 2016
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux
Pri: 2
Type: Bug

Blocked on:
issue 591248



Sign in to add a comment

Revert WebRTC libfuzzer bots back to pinned Clang

Project Member Reported by kjellander@chromium.org, Mar 1 2016

Issue description

In order to unblock us from rolling chromium_revision in WebRTC DEPS, we have to start setting
LLVM_FORCE_HEAD_REVISION=True
in the bot's environment again. This is due to a new file being introduced in the GN files of src/testing. That file is missing unless Clang is rolled (which can take a while) or you use HEAD Clang (we don't, since that risks breaking the bot at any time).


This bug tracks moving over to using LLVM_FORCE_HEAD_REVISION again, while waiting for  bug 591008  to be fixed. Then we should remove it again.

See https://code.google.com/p/chromium/codesearch#chromium/src/tools/clang/scripts/update.py for details on how the update procedure works.
 
Project Member

Comment 1 by bugdroid1@chromium.org, Mar 2 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/tools/build.git/+/6b65a8fec8f19c6e8e47a98278de0730e373f815

commit 6b65a8fec8f19c6e8e47a98278de0730e373f815
Author: kjellander@chromium.org <kjellander@chromium.org>
Date: Wed Mar 02 05:49:39 2016

WebRTC: Temporarily make libfuzzer bot use HEAD Clang.

While waiting for  crbug.com/591008  to be fixed, we have to do this
to unblock rolling chromium_revision in WebRTC DEPS.
This risks breaking the bot if something bad goes into Clang ToT, but
we'll handle that if it happens by removing the bot from CQ.

BUG= 591022 

Review URL: https://codereview.chromium.org/1751613003

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/build@299044 0039d316-1c4b-4281-b951-d872f2087c98

[modify] https://crrev.com/6b65a8fec8f19c6e8e47a98278de0730e373f815/scripts/slave/recipes/webrtc/libfuzzer.expected/full_client_webrtc_Linux64_Release__Libfuzzer_.json
[modify] https://crrev.com/6b65a8fec8f19c6e8e47a98278de0730e373f815/scripts/slave/recipes/webrtc/libfuzzer.expected/full_tryserver_webrtc_linux_libfuzzer_rel.json
[modify] https://crrev.com/6b65a8fec8f19c6e8e47a98278de0730e373f815/scripts/slave/recipes/webrtc/libfuzzer.py

It turns out the approach in  bug 591008  was dropped in favor of a another approach, which is tracked in  bug 591248 .
Project Member

Comment 3 by bugdroid1@chromium.org, Mar 2 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/tools/build.git/+/3ea6072127c4608670ccbe1854ce93c7b2624542

commit 3ea6072127c4608670ccbe1854ce93c7b2624542
Author: kjellander@chromium.org <kjellander@chromium.org>
Date: Wed Mar 02 10:40:18 2016

Revert of WebRTC: Temporarily make libfuzzer bot use HEAD Clang. (patchset #1 id:1 of https://codereview.chromium.org/1751613003/ )

Reason for revert:
This didn't work and also meant that the trybot always break.

Original issue's description:
> WebRTC: Temporarily make libfuzzer bot use HEAD Clang.
> 
> While waiting for  crbug.com/591008  to be fixed, we have to do this
> to unblock rolling chromium_revision in WebRTC DEPS.
> This risks breaking the bot if something bad goes into Clang ToT, but
> we'll handle that if it happens by removing the bot from CQ.
> 
> BUG= 591022 
> 
> Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=299044

TBR=pbos@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG= 591022 

Review URL: https://codereview.chromium.org/1757843002

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/build@299046 0039d316-1c4b-4281-b951-d872f2087c98

[modify] https://crrev.com/3ea6072127c4608670ccbe1854ce93c7b2624542/scripts/slave/recipes/webrtc/libfuzzer.expected/full_client_webrtc_Linux64_Release__Libfuzzer_.json
[modify] https://crrev.com/3ea6072127c4608670ccbe1854ce93c7b2624542/scripts/slave/recipes/webrtc/libfuzzer.expected/full_tryserver_webrtc_linux_libfuzzer_rel.json
[modify] https://crrev.com/3ea6072127c4608670ccbe1854ce93c7b2624542/scripts/slave/recipes/webrtc/libfuzzer.py

Status: WontFix (was: Assigned)
Since we couldn't switch to HEAD, there's nothing more to be done here for now.
I will reopen when/if we should try this again.
Project Member

Comment 5 by bugdroid1@chromium.org, Mar 22 2016

The following revision refers to this bug:
  http://goto.ext.google.com/viewvc/chrome-internal?view=rev&revision=84761

------------------------------------------------------------------
r84761 | recipe-roller@chromium.org | 2016-03-04T03:44:36.473049Z

-----------------------------------------------------------------

Comment 6 by benhenry@google.com, Apr 27 2016

Components: Infra>Client>WebRTC
Labels: -Infra-Client-WebRTC

Sign in to add a comment