New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 590995 link

Starred by 1 user
Status: Fixed
Owner:
u...@chromium.org
Closed: Mar 2016
Cc:
█ hpayer@chromium.org
hablich@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug



Sign in to add a comment

Make all memory reducing GCs incremental

Project Member Reported by u...@chromium.org, Mar 1 2016 
Currently non-incremental GCs causing critical 300ms lag in Google Inbox.


We already fixed this issue in M50. I am creating this issue to request a merge in M49.

The CL https://codereview.chromium.org/1693813002/ has 3 weeks Canary coverage and is safe.

Comment 1 by hablich@chromium.org, Mar 1 2016

Labels: -Merge-Request-49 Merge-Approved-49

Comment 2 by hablich@chromium.org, Mar 1 2016 

Out of curiosity: How do you know this results in a 300 Ms regression?

Comment 3 by u...@chromium.org, Mar 1 2016 

Thanks!

GC trace shows non-incremental 300ms GCs in inbox.
Project Member

Comment 4 by bugdroid1@chromium.org, Mar 1 2016

Labels: merge-merged-4.9
The following revision refers to this bug:
  https://chromium.googlesource.com/v8/v8.git/+/163a909154febf5498ee60efe0f4aab09be21515

commit 163a909154febf5498ee60efe0f4aab09be21515
Author: Ulan Degenbaev <ulan@chromium.org>
Date: Tue Mar 01 17:56:16 2016

Version 4.9.385.28 (cherry-pick)

Merged ea39270193e27aeca34965ede0db8c05932dce04

Make all GCs from memory reducer incremental.

R=hablich@chromium.org
BUG= chromium:590995 
LOG=NO

Review URL: https://codereview.chromium.org/1751073002 .

Cr-Commit-Position: refs/branch-heads/4.9@{#34}
Cr-Branched-From: 2fea296569597e5064f81fd8fce58f1848de261a-refs/heads/4.9.385@{#1}
Cr-Branched-From: 0c1430ac2b65847559d6a09f883ee7e5a91063c9-refs/heads/master@{#33306}

[modify] https://crrev.com/163a909154febf5498ee60efe0f4aab09be21515/include/v8-version.h
[modify] https://crrev.com/163a909154febf5498ee60efe0f4aab09be21515/src/heap/memory-reducer.cc

Comment 5 by u...@chromium.org, Mar 21 2016

Status: Fixed (was: Assigned)
Project Member

Comment 6 by sheriffbot@chromium.org, Apr 29 2016 

This issue has been approved for a merge. Please merge the fix to any appropriate branches as soon as possible!

If all merges have been completed, please remove any remaining Merge-Approved labels from this issue.

Thanks for your time! To disable nags, add the Disable-Nags label.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot

Comment 7 by u...@chromium.org, Apr 29 2016

Labels: -Merge-Approved-49
►

Sign in to add a comment