New issue
Advanced search Search tips

Issue 590992 link

Starred by 1 user
Status: Fixed
Owner:
yangguo@chromium.org
Closed: Mar 2016
Components:
EstimatedDays: ----
NextAction: ----
OS: All
Pri: 2
Type: Bug-Regression



Sign in to add a comment

Layout test failures due to debug break location changes in V8.

Project Member Reported by yangguo@chromium.org, Mar 1 2016 
V8 is introducing subtle changes to break locations for variable declarations. As result, some inspector layout tests need to be adapted.

- End of a script no longer has a break location for the implicitly added return value.
- Variable declarations without initialization no longer break (because this cannot be implemented in the interpreter).

https://codereview.chromium.org/1744123003/

Comment 1 by yangguo@chromium.org, Mar 1 2016 

Affected tests:
inspector/sources/debugger-step/debugger-step-into-async1-expected.txt
inspector/sources/debugger-step/debugger-step-into-document-write.html
inspector/sources/debugger-step/debugger-step-into-inlined-scripts.html
inspector/sources/debugger-step/debugger-step-over-document-write.html
inspector/sources/debugger-step/debugger-step-over-inlined-scripts.html
Project Member

Comment 2 by bugdroid1@chromium.org, Mar 1 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/274f768193139433768d21986980aa8050e7541d

commit 274f768193139433768d21986980aa8050e7541d
Author: yangguo <yangguo@chromium.org>
Date: Tue Mar 01 12:03:00 2016

LayoutTests: prepare inspector/debugger-step tests for V8 debugger change.

- End of a script will no longer has a break location for the implicitly
  added return value.
- Variable declarations without initialization will no longer break
  (because this cannot be implemented in the interpreter).

R=jochen@chromium.org
BUG= chromium:590992 

Review URL: https://codereview.chromium.org/1751803002

Cr-Commit-Position: refs/heads/master@{#378425}

[modify] https://crrev.com/274f768193139433768d21986980aa8050e7541d/third_party/WebKit/LayoutTests/TestExpectations
[modify] https://crrev.com/274f768193139433768d21986980aa8050e7541d/third_party/WebKit/LayoutTests/inspector/sources/debugger-step/debugger-step-into-async1-expected.txt
[modify] https://crrev.com/274f768193139433768d21986980aa8050e7541d/third_party/WebKit/LayoutTests/inspector/sources/debugger-step/debugger-step-into-document-write-expected.txt
[modify] https://crrev.com/274f768193139433768d21986980aa8050e7541d/third_party/WebKit/LayoutTests/inspector/sources/debugger-step/debugger-step-into-document-write.html
[modify] https://crrev.com/274f768193139433768d21986980aa8050e7541d/third_party/WebKit/LayoutTests/inspector/sources/debugger-step/debugger-step-into-inlined-scripts-expected.txt
[modify] https://crrev.com/274f768193139433768d21986980aa8050e7541d/third_party/WebKit/LayoutTests/inspector/sources/debugger-step/debugger-step-into-inlined-scripts.html
[modify] https://crrev.com/274f768193139433768d21986980aa8050e7541d/third_party/WebKit/LayoutTests/inspector/sources/debugger-step/debugger-step-over-document-write-expected.txt
[modify] https://crrev.com/274f768193139433768d21986980aa8050e7541d/third_party/WebKit/LayoutTests/inspector/sources/debugger-step/debugger-step-over-document-write.html
[modify] https://crrev.com/274f768193139433768d21986980aa8050e7541d/third_party/WebKit/LayoutTests/inspector/sources/debugger-step/debugger-step-over-inlined-scripts-expected.txt
[modify] https://crrev.com/274f768193139433768d21986980aa8050e7541d/third_party/WebKit/LayoutTests/inspector/sources/debugger-step/debugger-step-over-inlined-scripts.html
Project Member

Comment 3 by bugdroid1@chromium.org, Mar 2 2016

Labels: Merge-Merged-master1
The following revision refers to this bug:
  https://chrome-internal.googlesource.com/bling/chromium.git/+/274f768193139433768d21986980aa8050e7541d

commit 274f768193139433768d21986980aa8050e7541d
Author: yangguo <yangguo@chromium.org>
Date: Tue Mar 01 12:03:00 2016
Project Member

Comment 4 by bugdroid1@chromium.org, Mar 7 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/d7ebd0d062e2acc2cb9c201dded94b50d4b87847

commit d7ebd0d062e2acc2cb9c201dded94b50d4b87847
Author: yangguo <yangguo@chromium.org>
Date: Mon Mar 07 12:58:39 2016

LayoutTests: rebaseline several tests after V8 updated.

R=machenbach@chromium.org
BUG= 257405 , 585724 , 590992 

Review URL: https://codereview.chromium.org/1769823002

Cr-Commit-Position: refs/heads/master@{#379544}

[modify] https://crrev.com/d7ebd0d062e2acc2cb9c201dded94b50d4b87847/third_party/WebKit/LayoutTests/TestExpectations

Comment 5 by yangguo@chromium.org, Mar 7 2016

Status: Fixed (was: Assigned)
►

Sign in to add a comment